Re: Review Request: add action collection to the corona

2009-03-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/268/#review432 --- trunk/KDE/kdelibs/plasma/corona.h

Re: Review Request: add action collection to the corona

2009-03-10 Thread Chani
On 2009-03-10 01:54:53, Marco Martin wrote: trunk/KDE/kdelibs/plasma/corona.h, line 167 http://reviewboard.kde.org/r/268/diff/1/?file=2158#file2158line167 perhaps would be useful an accessor for the whole action collection? now from the ui i can call them by name, dunno how it

Re: Review Request: add action collection to the corona

2009-03-10 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/268/#review441 --- needs some clean ups here and there, but the general direction seems

Re: Review Request: add action collection to the corona

2009-03-10 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/268/#review443 --- if I add a function for getting the whole collection... should I expose

Re: Review Request: add action collection to the corona

2009-03-10 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/268/ --- (Updated 2009-03-10 12:12:56.043881) Review request for Plasma and Marco Martin.

Re: Review Request: add action collection to the corona

2009-03-10 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/268/#review445 --- Ship it! - Aaron On 2009-03-10 12:12:56, Chani wrote:

Review Request: add action collection to the corona

2009-03-09 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/268/ --- Review request for Plasma and Marco Martin. Summary --- some of the actions