Review Request: fix data leak in dataengines

2010-06-08 Thread Beat Wolf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4261/ --- Review request for Plasma. Summary --- fix the data "leak" introduced by ht

Re: Review Request: fix data leak in dataengines

2010-06-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4261/#review6044 --- Ship it! should work. is this new api necessary? - Marco On 2010-0

Re: Review Request: fix data leak in dataengines

2010-06-08 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4261/#review6047 --- John's commit should just be reverted and the calendar dataengine chan

Re: Review Request: fix data leak in dataengines

2010-06-09 Thread Beat Wolf
> On 2010-06-09 01:06:51, Aaron Seigo wrote: > > John's commit should just be reverted and the calendar dataengine changed > > properly. this penalizes the common case and adds more complexity that is > > uneeded, and the calendar dataengine really ought to list all holidays for > > the same d

Re: Review Request: fix data leak in dataengines

2010-06-09 Thread Beat Wolf
> On 2010-06-09 01:06:51, Aaron Seigo wrote: > > John's commit should just be reverted and the calendar dataengine changed > > properly. this penalizes the common case and adds more complexity that is > > uneeded, and the calendar dataengine really ought to list all holidays for > > the same d

Re: Review Request: fix data leak in dataengines

2010-06-09 Thread John Layt
> On 2010-06-09 01:06:51, Aaron Seigo wrote: > > John's commit should just be reverted and the calendar dataengine changed > > properly. this penalizes the common case and adds more complexity that is > > uneeded, and the calendar dataengine really ought to list all holidays for > > the same d