Re: Review Request: increased binary clock applet minimum size

2012-07-27 Thread Reza Shah
On July 26, 2012, 10:23 a.m., Marco Martin wrote: it should depend from the border size as well. right now it would break panels less that 40 px tall. My patch only for placement at desktop. Does it also affect the placement at panel? - Reza

Re: Review Request: increased binary clock applet minimum size

2012-07-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105577/#review16546 --- Ship it! Ship It! - Marco Martin On July 15, 2012, 12:19

Re: Review Request: increased binary clock applet minimum size

2012-07-27 Thread Marco Martin
On July 26, 2012, 10:23 a.m., Marco Martin wrote: it should depend from the border size as well. right now it would break panels less that 40 px tall. Reza Shah wrote: My patch only for placement at desktop. Does it also affect the placement at panel? yeah, in this case the

Re: Review Request: increased binary clock applet minimum size

2012-07-27 Thread Reza Shah
On July 27, 2012, 7:41 p.m., Marco Martin wrote: Ship It! Other than master. Is it ok to push to 4.9.0? Or should go to 4.9.1? - Reza --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request: increased binary clock applet minimum size

2012-07-27 Thread Marco Martin
On July 27, 2012, 7:41 p.m., Marco Martin wrote: Ship It! Reza Shah wrote: Other than master. Is it ok to push to 4.9.0? Or should go to 4.9.1? KDE/4.9 branch is fine, yes - Marco --- This is an automatically generated

Re: Review Request: increased binary clock applet minimum size

2012-07-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105577/#review16552 --- This review has been submitted with commit

Re: Review Request: increased binary clock applet minimum size

2012-07-27 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105577/#review16554 --- Has this been committed to master as well? - Ben Cooksley

Re: Review Request: increased binary clock applet minimum size

2012-07-27 Thread Reza Shah
On July 27, 2012, 9:17 p.m., Ben Cooksley wrote: Has this been committed to master as well? Yes, http://commits.kde.org/kdeplasma-addons/a333b14dac7323f5a84d79835548c11ae067667f - Reza --- This is an automatically generated e-mail.

Re: Review Request: increased binary clock applet minimum size

2012-07-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105577/#review16470 --- it should depend from the border size as well. right now it

Review Request: increased binary clock applet minimum size

2012-07-15 Thread Reza Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105577/ --- Review request for Plasma and Davide Bettio. Description --- bug