Re: Review Request: new KWin effect: Dashboard

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4332/#review6689 --- Ship it! At least for KWin part this is a ship It. If nobody comments

Re: Review Request: new KWin effect: Dashboard

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4332/ --- (Updated 2010-07-21 13:52:16.384053) Review request for kwin and Plasma. Chang

Re: Review Request: new KWin effect: Dashboard

> On 2010-07-05 06:16:45, Martin Gräßlin wrote: > > trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp, > > lines 58-62 > > > > > > I'm not really sure if it is a good idea to make the blur option onl

Re: Review Request: new KWin effect: Dashboard

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4332/#review6365 --- There are only small issues left - mostly coding style. Yeah I know KW

Re: Review Request: new KWin effect: Dashboard

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4332/ --- (Updated 2010-06-29 19:29:38.209000) Review request for kwin and Plasma. Chang

Re: Review Request: new KWin effect: Dashboard

> On 2010-06-16 18:12:50, Martin Gräßlin wrote: > > I must agree with Aaron: I'm really glad we finally get a Dashboard effect > > (I remember that I wrote one about 4.1, but at that time Dashboard was so > > broken that I stopped working on it :-P) > > > > I'm not sure about the config option

Re: Review Request: new KWin effect: Dashboard

> On 2010-06-16 18:12:50, Martin Gräßlin wrote: > > I must agree with Aaron: I'm really glad we finally get a Dashboard effect > > (I remember that I wrote one about 4.1, but at that time Dashboard was so > > broken that I stopped working on it :-P) > > > > I'm not sure about the config option

Re: Review Request: new KWin effect: Dashboard

> On 2010-06-15 20:55:30, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp, lines > > 100-113 > > > > > > that is quite the hack; this should be replaced with another method in > >

Re: Review Request: new KWin effect: Dashboard

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4332/#review6145 --- I must agree with Aaron: I'm really glad we finally get a Dashboard ef

Re: Review Request: new KWin effect: Dashboard

> On 2010-06-15 20:55:30, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp, line 36 > > > > > > _KDE_DASHBOARD is a bit generic; i wonder if we should be namespacing > > these a bit

Re: Review Request: new KWin effect: Dashboard

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4332/#review6130 --- nice to see this moving forward! it looks ok from the plasma side, tho

Review Request: new KWin effect: Dashboard

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4332/ --- Review request for kwin and Plasma. Summary --- This patch adds a new KWin