Re: Review Request: new meter theming approach

2008-10-26 Thread Riccardo Iaconelli
On Saturday 25 October 2008 12:57:04 Marco Martin wrote: > it does have a problem, when the number of tiles is not integer  it rounds > to the lower integer and mover the progressbar pattern at the centr, so > there are little margins at both sides. maybe not reeally pretty but still > better than

Re: Review Request: new meter theming approach

2008-10-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/239/ --- (Updated 2008-10-25 03:57:03.852304) Review request for Plasma. Summary -

Re: Review Request: new meter theming approach

2008-10-24 Thread Rob Scheepmaker
On Friday 24 October 2008 18:15:53 Marco Martin wrote: > On Friday 24 October 2008, Rob Scheepmaker wrote: > > What if you add an element to the svg which indicates the tiles 'natural' > > height/weight ratio. The golden ratio is a good start, but I think themes > > should be able to customize this

Re: Review Request: new meter theming approach

2008-10-24 Thread Marco Martin
On Friday 24 October 2008, Rob Scheepmaker wrote: > On Friday 24 October 2008 12:24:03 Marco Martin wrote: > > > On 2008-10-23 23:19:59, Petri Damstén wrote: > > > > /trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp, line 122 > > > >

Re: Review Request: new meter theming approach

2008-10-24 Thread Petri Damstén
On Friday 24 October 2008 13:24:03 you wrote: > yes, the old one still works, can be used to make solid progressbars or > yeah, termomenters (hmm would need an additional id for the bulb that > shouldn't be scaled or at least scaled always with a 1:1 ratio) Might be hard to get all the special cas

Re: Review Request: new meter theming approach

2008-10-24 Thread Rob Scheepmaker
On Friday 24 October 2008 12:24:03 Marco Martin wrote: > > On 2008-10-23 23:19:59, Petri Damstén wrote: > > > /trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp, line 122 > > > > >22> > > > > > > * Fixed tile widt

Re: Review Request: new meter theming approach

2008-10-24 Thread Marco Martin
> On 2008-10-23 23:19:59, Petri Damstén wrote: > > /trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp, line 122 > > > > > > * Fixed tile width/height ratio? > > yeah, kinda, since panelsvg does not really have

Re: Review Request: new meter theming approach

2008-10-23 Thread Petri Damstén
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/239/#review233 --- Looks good. /trunk/KDE/kdebase/workspace/libs/plasma/widgets/met

Review Request: new meter theming approach

2008-10-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/239/ --- Review request for Plasma. Summary --- the old theming for Plasma::Met