Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/#review24870 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 6, 2013, 11:53

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/#review24913 --- This review has been submitted with commit

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/#review24834 --- The code basically is fine, except that you could make the OSD

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-06 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/ --- (Updated Jan. 6, 2013, 10:25 p.m.) Review request for kde-workspace,

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-06 Thread Kai Uwe Broulik
On Jan. 6, 2013, 3:45 p.m., Kai Uwe Broulik wrote: Just applied the patch from Review 107983 and your patch resolves the issue. Would you mind if I use that code to fix KMix OSD? Xuetian Weng wrote: Well.. actually I have a review for kmix :P

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-06 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/ --- (Updated Jan. 6, 2013, 11:53 p.m.) Review request for kde-workspace,