Re: Review Request 108316: Show album art in krunner results.

2013-01-12 Thread Emil Sedgh
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108316/ --- (Updated Jan. 12, 2013, 3:46 p.m.) Review request for Plasma. Changes

Re: Review Request 108316: Show album art in krunner results.

2013-01-12 Thread Emil Sedgh
On Jan. 12, 2013, 1:18 a.m., Christoph Feck wrote: Regarding the QPixmap thread warning, there is a auxiliary icon engine somewhere in the contacts runner, which uses passes QImage data around. QImage can be used outside the UI thread. Thank you Christoph. It's not throwing warnings

Re: Review Request 108316: Show album art in krunner results.

2013-01-12 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108316/#review25305 --- Ship it! couple minor comments below, but looks ready to be

Re: Review Request 108316: Show album art in krunner results.

2013-01-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108316/#review25310 --- This review has been submitted with commit