Re: Review Request 108664: Remove absolute paths from Plasma/Generic packages

2013-01-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108664/#review26395 --- This review has been submitted with commit d291d3affde58b54fa4

Re: Review Request 108664: Remove absolute paths from Plasma/Generic packages

2013-01-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108664/#review26394 --- This review has been submitted with commit 4eccd4cc7fd13e89393

Re: Review Request 108664: Remove absolute paths from Plasma/Generic packages

2013-01-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108664/#review26393 --- This review has been submitted with commit 717ff8c46d6b1e7ecdc

Re: Review Request 108664: Remove absolute paths from Plasma/Generic packages

2013-01-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108664/ --- (Updated Jan. 30, 2013, 8:43 a.m.) Review request for Plasma, Marco Martin

Re: Review Request 108664: Remove absolute paths from Plasma/Generic packages

2013-01-29 Thread Sebastian Kügler
> On Jan. 29, 2013, 10:51 p.m., Sebastian Kügler wrote: > > Patch looks good, code *now* does what I'd expect it to. > > > > I've tested it, and it fixes the issue. > > > > A grep through my src checkouts reveals 29 uses of PackageStructure with > > Plasma/Generic, so the work to check it all

Re: Review Request 108664: Remove absolute paths from Plasma/Generic packages

2013-01-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108664/#review26386 --- Ship it! Patch looks good, code *now* does what I'd expect it

Re: Review Request 108664: Remove absolute paths from Plasma/Generic packages

2013-01-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108664/ --- (Updated Jan. 29, 2013, 8:07 p.m.) Review request for Plasma, Marco Martin

Review Request 108664: Remove absolute paths from Plasma/Generic packages

2013-01-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108664/ --- Review request for Plasma, Marco Martin and Sebastian Kügler. Description