Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110701/#review35072 --- This review has been submitted with commit dfc81cd32181f3f6cb4

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110701/#review35070 --- This review has been submitted with commit 0e0b98c373a8fd68e1f

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110701/ --- (Updated June 25, 2013, 7:17 p.m.) Status -- This change has been mar

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

> On June 20, 2013, 2:59 p.m., Aaron J. Seigo wrote: > > > > Wolfgang Bauer wrote: > Thank you! > > But this somehow depends on https://git.reviewboard.kde.org/r/110716/ > because the same text color should be used everywhere (either > Plasma::Theme::TextColor or Plasma::Theme::Bu

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

> On June 20, 2013, 4:59 p.m., Aaron J. Seigo wrote: > > Thank you! But this somehow depends on https://git.reviewboard.kde.org/r/110716/ because the same text color should be used everywhere (either Plasma::Theme::TextColor or Plasma::Theme::ButtonTextColor). Could you have a look at that re

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110701/ --- (Updated June 20, 2013, 8:12 p.m.) Review request for Plasma and Anne-Mari

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110701/#review34778 --- Ship it! applets/notes/notes.cpp

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110701/ --- (Updated June 20, 2013, 4:22 p.m.) Review request for Plasma and Anne-Mari

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

> On June 20, 2013, 2:13 p.m., Aaron J. Seigo wrote: > > instead of this common idiom over and over (which also introduces the same > > strings repeatedly, which means changes in future need to be made in > > several places): > > > > textIsBright() ? "black" : "yellow" > > > > why not cha

Re: Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110701/#review34750 --- instead of this common idiom over and over (which also introduc

Review Request 110701: Make the notes plasmoid change the background color according to the current plasma theme's text color

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110701/ --- Review request for Plasma and Anne-Marie Mahfouf. Description --- The