Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- Review request for Plasma. Description --- This adds support for the

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-20 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/#review34738 --- plasma/declarativeimports/core/datamodel.h

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 20, 2013, 9:41 a.m.) Review request for Plasma. Changes --

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-20 Thread Marco Martin
> On June 20, 2013, 9:20 a.m., Aaron J. Seigo wrote: > > plasma/declarativeimports/core/datamodel.h, line 94 > > > > > > is this necessary, given that there is a setSortCaseSensitivity in the > > parent class? yo

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-20 Thread Marco Martin
> On June 20, 2013, 9:20 a.m., Aaron J. Seigo wrote: > > plasma/declarativeimports/core/datamodel.h, line 94 > > > > > > is this necessary, given that there is a setSortCaseSensitivity in the > > parent class? >

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-20 Thread Sebastian Kügler
On Thursday, June 20, 2013 08:57:17 Kai Uwe Broulik wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/48/ > --- > > Review

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/#review34813 --- the patch is almost ok, tough can you still find a way to make

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-22 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 22, 2013, 2:42 p.m.) Review request for Plasma. Changes --

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-22 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/#review34881 --- Ship it! For absolute completeness, the sortCaseSensitivity pr

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-22 Thread Marco Martin
> On June 22, 2013, 3:24 p.m., Aaron J. Seigo wrote: > > For absolute completeness, the sortCaseSensitivity property should also > > have a NOTIFY signal .. but i don't see why anyone would ever bind to that > > signal and it would require a reimplementation of the set method, so i'm > > fine

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/#review34884 --- This review has been submitted with commit 49fcb63e705420da8dc

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/48/ --- (Updated June 22, 2013, 3:30 p.m.) Status -- This change has been mar

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-24 Thread Sebastian Kügler
Kai-Uwe, Do you want to forward-port this patch to plasma-framework, or should I do it? (I sense that this might be the reason for CCMAILing me. :-)) -- sebas On Thursday, June 20, 2013 08:57:17 Kai Uwe Broulik wrote: > --- > This is an au