Re: Review Request 112674: Bugfix: Make the calculator applet calculate correct

2013-09-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112674/#review39846 --- Almost good, two nitpicks inside.

Review Request 112674: Bugfix: Make the calculator applet calculate correct

2013-09-11 Thread Paul Rohrbach
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112674/ --- Review request for Plasma. Description --- This patch should solve

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correct

2013-09-11 Thread Paul Rohrbach
On Sept. 11, 2013, 5:28 p.m., Sebastian Kügler wrote: applets/calculator/package/contents/ui/calculator.qml, line 41 http://git.reviewboard.kde.org/r/112674/diff/1/?file=188980#file188980line41 Why is this change needed (operator initialized to undefined)? This should not be part