Review Request 113207: Plasmate: Request for merge, branch plasmoidviewer2 to frameworks-scratch

2013-10-11 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113207/ --- Review request for Plasma. Repository: plasmate Description --- The

Re: Review Request 113207: Plasmate: Request for merge, branch plasmoidviewer2 to frameworks-scratch

2013-10-12 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113207/#review41613 --- Ship it! Code looks pretty good, there's a bunch of nitpicks,

Re: Review Request 113207: Plasmate: Request for merge, branch plasmoidviewer2 to frameworks-scratch

2013-10-15 Thread Antonis Tsiapaliokas
> On Oct. 12, 2013, 7:20 p.m., Sebastian Kügler wrote: > > plasmoidviewer/main.cpp, line 151 > > > > > > The [null] is confusing. What's the idea here? the purpose of the null, is that it represents the default v

Re: Review Request 113207: Plasmate: Request for merge, branch plasmoidviewer2 to frameworks-scratch

2013-10-15 Thread Sebastian Kügler
> On Oct. 12, 2013, 7:20 p.m., Sebastian Kügler wrote: > > plasmoidviewer/main.cpp, line 151 > > > > > > The [null] is confusing. What's the idea here? > > Antonis Tsiapaliokas wrote: > the purpose of the nul

Re: Review Request 113207: Plasmate: Request for merge, branch plasmoidviewer2 to frameworks-scratch

2013-10-15 Thread Giorgos Tsiapaliokas
> On Oct. 12, 2013, 7:20 p.m., Sebastian Kügler wrote: > > Code looks pretty good, there's a bunch of nitpicks, but mostly minor stuff. > > > > What I'm not happy about is the amount of -- apparently -- copied code, the > > shell package and the containment. If we need those things, plasmate sh

Re: Review Request 113207: Plasmate: Request for merge, branch plasmoidviewer2 to frameworks-scratch

2013-10-16 Thread Marco Martin
> On Oct. 12, 2013, 7:20 p.m., Sebastian Kügler wrote: > > Code looks pretty good, there's a bunch of nitpicks, but mostly minor stuff. > > > > What I'm not happy about is the amount of -- apparently -- copied code, the > > shell package and the containment. If we need those things, plasmate sh

Re: Review Request 113207: Plasmate: Request for merge, branch plasmoidviewer2 to frameworks-scratch

2013-11-15 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113207/ --- (Updated Nov. 15, 2013, 1:08 p.m.) Status -- This change has been mar