Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/ --- (Updated Oct. 28, 2013, 11:17 p.m.) Status -- This change has been ma

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/#review42562 --- This review has been submitted with commit 148dea659dbe3583a30

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Michael Zanetti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/#review42503 --- Confirming that this prevents plasma from crashing for me. With

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Albert Astals Cid
> On Oct. 27, 2013, 11:05 a.m., Christoph Feck wrote: > > Ah, that makes sense, thanks for your investigation! > > > > What could be done to improve it, is to let the timer fire again sometimes > > later, until the item could actually be removed. I am not sure, though, if > > it is needed, in

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Christoph Feck
> On Oct. 27, 2013, 11:05 a.m., Christoph Feck wrote: > > Ah, that makes sense, thanks for your investigation! > > > > What could be done to improve it, is to let the timer fire again sometimes > > later, until the item could actually be removed. I am not sure, though, if > > it is needed, in

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/#review42444 --- Ship it! not pretty, but it works. one small code issue below

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Albert Astals Cid
> On Oct. 27, 2013, 11:05 a.m., Christoph Feck wrote: > > Ah, that makes sense, thanks for your investigation! > > > > What could be done to improve it, is to let the timer fire again sometimes > > later, until the item could actually be removed. I am not sure, though, if > > it is needed, in

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/#review42418 --- Ah, that makes sense, thanks for your investigation! What coul

Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/ --- Review request for kde-workspace, Plasma, Àlex Fiestas, and Michael Zanetti.