Review Request 114925: Add a new component ModelMenu

2014-01-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114925/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 114925: Add a new component ModelMenu

2014-01-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114925/#review47104 --- Maybe call it ModelContextMenu? - Aleix Pol Gonzalez On Jan

Re: Review Request 114925: Add a new component ModelMenu

2014-01-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114925/#review47109 --- Have you thought about folding this into ContextMenu, so we do

Re: Review Request 114925: Add a new component ModelMenu

2014-01-09 Thread David Edmundson
> On Jan. 9, 2014, 2:15 p.m., Sebastian Kügler wrote: > > Have you thought about folding this into ContextMenu, so we don't need an > > extra component? I thought about it. Then gave up :) Problem comes from having an interface which now has to support: - a QList - a QAbstractItemModel - _a

Re: Review Request 114925: Add a new component ModelMenu

2014-01-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114925/ --- (Updated Jan. 9, 2014, 4:14 p.m.) Review request for Plasma. Changes --

Re: Review Request 114925: Add a new component ModelMenu

2014-01-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114925/#review47112 --- Ship it! Looking nice and clean. src/declarativeimports/pla

Re: Review Request 114925: Add a new component ModelMenu

2014-01-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114925/#review47135 --- This review has been submitted with commit d200bd0d16566c4427

Re: Review Request 114925: Add a new component ModelMenu

2014-01-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114925/ --- (Updated Jan. 10, 2014, 11:28 a.m.) Status -- This change has been m