Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/ --- (Updated Feb. 28, 2014, 3:23 p.m.) Status -- This change has been ma

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review51343 --- This review has been submitted with commit 66bac622b4e2a26809

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review51342 --- [16:00] so, if you are sure nothing is leaking (ii still not

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 21, 2014, 11:18 p.m., Sebastian Kügler wrote: > > I've run your native_render_frame branch for a bit, some observations on my > > system: > > > > - It mostly works > > - taskbar doesn't find some elements in the svg, leading to lots of > > messages like this: > > plasma_shell(11872)/

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

On Tuesday 25 February 2014, David Edmundson wrote: > Is that with the branch or with this patch? They are quite diverged at > this point? with the branch -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/li

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

Is that with the branch or with this patch? They are quite diverged at this point? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 21, 2014, 11:18 p.m., Sebastian Kügler wrote: > > I've run your native_render_frame branch for a bit, some observations on my > > system: > > > > - It mostly works > > - taskbar doesn't find some elements in the svg, leading to lots of > > messages like this: > > plasma_shell(11872)/

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

On Monday 24 February 2014, Marco Martin wrote: > here the main problem seems that is broken the rendering of a single svg > element. > so for things like the expander arrows in the taskbar, the whole svg is > rendered and the sizes of the items seems also to be reported incorrectly > (so for insta

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

On Saturday 22 February 2014, Sebastian Kügler wrote: > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115923/#review50494 > --- >

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review50494 --- I've run your native_render_frame branch for a bit, some obser

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/ --- (Updated Feb. 21, 2014, 3:32 p.m.) Review request for Plasma. Changes -

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/ --- (Updated Feb. 21, 2014, 2:15 p.m.) Review request for Plasma. Repositor

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 20, 2014, 9:13 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/svgitem.cpp, line 133 > > > > > > Q_NULLPTR it's still in the latest diff - Martin ---

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 20, 2014, 9:13 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/svgitem.cpp, line 127 > > > > > > nitpick: looking at the surrounding coding style the * should be moved > > from type to name

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review50424 --- src/declarativeimports/core/svgitem.cpp

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review50423 --- src/declarativeimports/core/svgitem.h

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/ --- (Updated Feb. 20, 2014, 11:45 p.m.) Review request for Plasma. Reposito

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 20, 2014, 8:13 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/svgitem.cpp, line 45 > > > > > > are you sure that you can delete the texture here? Is the object being > > destroyed from the

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 20, 2014, 9:13 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/svgitem.cpp, line 127 > > > > > > nitpick: looking at the surrounding coding style the * should be moved > > from type to name

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 20, 2014, 9:13 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/svgitem.cpp, line 45 > > > > > > are you sure that you can delete the texture here? Is the object being > > destroyed from the

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 20, 2014, 8:13 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/svgitem.cpp, line 132 > > > > > > I never really understood who takes ownership over the nodes: does one > > have to delete th

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

> On Feb. 20, 2014, 7:54 p.m., Marco Martin wrote: > > src/declarativeimports/core/svgitem.cpp, line 138 > > > > > > is this guaranteed to be always deleted? I believe so. There's a flag on QGSNode QSGNode::Own

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review50402 --- src/declarativeimports/core/svgitem.cpp

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review50401 --- pretty much good to go i think src/declarativeimports/core/s

Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review50398 --- src/declarativeimports/core/svgitem.cpp

Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/ --- Review request for Plasma. Repository: plasma-framework Description ---