Review Request 116085: welcome back the javascript interactive console

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 116085: welcome back the javascript interactive console

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/#review50941 --- src/shell/interactiveconsole.h

Re: Review Request 116085: welcome back the javascript interactive console

> On Feb. 26, 2014, 3:47 p.m., David Edmundson wrote: > > src/shell/interactiveconsole.cpp, line 57 > > > > > > Are you not doing that on line 130? yeah, comes from the copy of the oold file ;) > On Feb. 26, 20

Re: Review Request 116085: welcome back the javascript interactive console

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/ --- (Updated Feb. 26, 2014, 4:03 p.m.) Review request for Plasma. Repositor

Re: Review Request 116085: welcome back the javascript interactive console

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/#review50960 --- Ship it! Ship It! - David Edmundson On Feb. 26, 2014, 4:03

Re: Review Request 116085: welcome back the javascript interactive console

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/ --- (Updated Feb. 26, 2014, 5:37 p.m.) Status -- This change has been ma

Re: Review Request 116085: welcome back the javascript interactive console

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/#review50963 --- This review has been submitted with commit 1fd741b5d30929d183

Re: Review Request 116085: welcome back the javascript interactive console

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116085/#review50965 --- src/shell/CMakeLists.txt

Re: Review Request 116085: welcome back the javascript interactive console

> On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote: > > src/shell/CMakeLists.txt, line 20 > > > > > > This would mean: > > a) propagate KTextEditor to part of the KF5 releases (that was not the > > case with

Re: Review Request 116085: welcome back the javascript interactive console

> On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote: > > src/shell/CMakeLists.txt, line 20 > > > > > > This would mean: > > a) propagate KTextEditor to part of the KF5 releases (that was not the > > case with

Re: Review Request 116085: welcome back the javascript interactive console

> On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote: > > src/shell/CMakeLists.txt, line 20 > > > > > > This would mean: > > a) propagate KTextEditor to part of the KF5 releases (that was not the > > case with

Re: Review Request 116085: welcome back the javascript interactive console

> On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote: > > src/shell/CMakeLists.txt, line 20 > > > > > > This would mean: > > a) propagate KTextEditor to part of the KF5 releases (that was not the > > case with

Re: Review Request 116085: welcome back the javascript interactive console

> On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote: > > src/shell/CMakeLists.txt, line 20 > > > > > > This would mean: > > a) propagate KTextEditor to part of the KF5 releases (that was not the > > case with

Re: Review Request 116085: welcome back the javascript interactive console

> On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote: > > src/shell/CMakeLists.txt, line 20 > > > > > > This would mean: > > a) propagate KTextEditor to part of the KF5 releases (that was not the > > case with