Re: Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering

2014-03-07 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116640/ --- (Updated March 7, 2014, 9:12 a.m.) Review request for Plasma, Shantanu

Re: Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering

2014-03-07 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116640/#review52336 --- Ship it! Cool, reordering now shows the correct media as

Re: Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering

2014-03-07 Thread Shantanu Tushar
On March 7, 2014, 12:15 p.m., Shantanu Tushar wrote: Cool, reordering now shows the correct media as active. Oops, please ignore this, I completely forgot to take a look at the diff itself (blame the hurry of leaving office on a friday evening :P). Will review the code asap. - Shantanu

Re: Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering

2014-03-07 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116640/ --- (Updated March 7, 2014, 1:50 p.m.) Review request for Plasma, Shantanu

Re: Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering

2014-03-07 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116640/#review52353 --- Seems to work as expected, but has few issues listed below.

Re: Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering

2014-03-07 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116640/ --- (Updated March 7, 2014, 3:44 p.m.) Review request for Plasma, Shantanu

Re: Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering

2014-03-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116640/#review52367 --- This review has been submitted with commit

Re: Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering

2014-03-07 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116640/ --- (Updated March 7, 2014, 4:27 p.m.) Status -- This change has been

Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering

2014-03-06 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116640/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: