Re: Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

2014-03-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/#review52454 --- This review has been submitted with commit 8567b0cf2db7e86eba

Re: Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

2014-03-09 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/ --- (Updated March 9, 2014, 3:50 p.m.) Status -- This change has been ma

Re: Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

2014-03-09 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/#review52440 --- Ship it! Looks good, please go ahead and push it. When pushin

Re: Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

2014-03-09 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/ --- (Updated March 9, 2014, 8:03 p.m.) Review request for Plasma, Shantanu Tu

Re: Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

2014-03-09 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/#review52439 --- Looks good and works as expected, just a bit of a problem here

Re: Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

2014-03-08 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/ --- (Updated March 9, 2014, 5:20 a.m.) Review request for Plasma, Shantanu Tu

Re: Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

2014-03-08 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/#review52423 --- Instead of getting the index in QML using indexInSourceModelOf

Re: Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

2014-03-08 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/ --- (Updated March 8, 2014, 7:34 p.m.) Review request for Plasma, Shantanu Tu

Re: Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

2014-03-08 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/#review52384 --- A better solution would be move the removeFromPlaylist() metho

Re: Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

2014-03-08 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/#review52383 --- A better solution would be move the removeFromPlaylist() metho

Review Request 116656: Fix for "Bug 331820 - Deleting items when searching removes the wrong items"

2014-03-08 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/ --- Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Harida