Re: Review Request 117452: [kglobalaccel] Port away from dead #ifdef Q_WS_X11

2014-04-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117452/ --- (Updated April 11, 2014, 5:43 a.m.) Status -- This change has been m

Re: Review Request 117452: [kglobalaccel] Port away from dead #ifdef Q_WS_X11

2014-04-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117452/#review55429 --- This review has been submitted with commit d888a16fb0f59ad665

Re: Review Request 117452: [kglobalaccel] Port away from dead #ifdef Q_WS_X11

2014-04-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117452/ --- (Updated April 10, 2014, 7:58 a.m.) Review request for Plasma. Changes

Re: Review Request 117452: [kglobalaccel] Port away from dead #ifdef Q_WS_X11

2014-04-09 Thread Martin Gräßlin
> On April 9, 2014, 6:33 p.m., Aleix Pol Gonzalez wrote: > > kglobalaccel/kglobalaccel_x11.cpp, line 289 > > > > > > Why don't you just delete it by hand? it's not like there's a return or > > anything... copy

Re: Review Request 117452: [kglobalaccel] Port away from dead #ifdef Q_WS_X11

2014-04-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117452/#review55294 --- Ship it! kglobalaccel/kglobalaccel_x11.cpp

Review Request 117452: [kglobalaccel] Port away from dead #ifdef Q_WS_X11

2014-04-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117452/ --- Review request for Plasma. Repository: plasma-workspace Description ---