Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated Aug. 20, 2014, 7:13 p.m.) Status -- This change has been ma

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review63445 --- weird issue when using reviewboard with the chrome. that why t

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated July 29, 2014, 3:24 p.m.) Review request for kde-workspace and P

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 3:19 p.m.) Status -- This change has been disc

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 2:15 p.m.) Review request for kde-workspace and Pla

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 10:05 a.m.) Review request for kde-workspace and Pl

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 10:04 a.m.) Review request for kde-workspace and Pl

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review63401 --- Reviewboard wasn't showing the patch, not sure why. We can't d

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated July 29, 2014, 9:43 a.m.) Status -- This change has been di

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62810 --- seems the patch doesn't apply anymore, at least reviewboard co

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 21, 2014, 1:12 p.m.) Review request for kde-workspace and Pla

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62784 --- modulo the indentation, it should be ok - Marco Martin On G

Re: Review Request 118180: slideshow BUG patch fix

> On 七月 21, 2014, 12:39 p.m., Martin Gräßlin wrote: > > > > TOM Harrison wrote: > what kind of issue? tab and space different ? > > Sebastian Kügler wrote: > Yes, don't use tabs at all for code indentation, use 4 spaces. It should > look consistent with the surrounding code after that.

Re: Review Request 118180: slideshow BUG patch fix

> On July 21, 2014, 12:39 p.m., Martin Gräßlin wrote: > > > > TOM Harrison wrote: > what kind of issue? tab and space different ? Yes, don't use tabs at all for code indentation, use 4 spaces. It should look consistent with the surrounding code after that. - Sebastian -

Re: Review Request 118180: slideshow BUG patch fix

> On 七月 21, 2014, 12:39 p.m., Martin Gräßlin wrote: > > what kind of issue? tab and space different ? - TOM --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62779 --

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62779 --- libs/plasmagenericshell/backgrounddialog.cpp

Re: Review Request 118180: slideshow BUG patch fix

> On 六月 5, 2014, 10:12 a.m., Christoph Feck wrote: > > Please add Plasma developers to the group of reviewers. > > > > Btw, you cannot give "Ship It" to yourself, others have to approve it. > > TOM Harrison wrote: > that just a wrong click :) > > TOM Harrison wrote: > thanks for remind

Re: Review Request 118180: slideshow BUG patch fix

> On June 5, 2014, 10:12 a.m., Christoph Feck wrote: > > Please add Plasma developers to the group of reviewers. > > > > Btw, you cannot give "Ship It" to yourself, others have to approve it. > > TOM Harrison wrote: > that just a wrong click :) > > TOM Harrison wrote: > thanks for remi

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated June 5, 2014, 10:32 a.m.) Review request for kde-workspace and P