Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

> On May 27, 2014, 4:12 p.m., Andrew Lake wrote: > > Ship It! > > Andrew Lake wrote: > In case anyone is wondering why this arbitrary fellow said "Ship It!", I > just wanted to provide an explicit thumbs up that this matches the 4px > spacing basis grid recommended in the HIG > (http://te

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58614 --- This review has been submitted with commit bec64684e8d3fb621c

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 10:38 p.m.) Status -- This change has been ma

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

> On May 27, 2014, 4:12 p.m., Andrew Lake wrote: > > Ship It! > > Andrew Lake wrote: > In case anyone is wondering why this arbitrary fellow said "Ship It!", I > just wanted to provide an explicit thumbs up that this matches the 4px > spacing basis grid recommended in the HIG > (http://te

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

> On May 27, 2014, 4:12 p.m., Andrew Lake wrote: > > Ship It! > > Andrew Lake wrote: > In case anyone is wondering why this arbitrary fellow said "Ship It!", I > just wanted to provide an explicit thumbs up that this matches the 4px > spacing basis grid recommended in the HIG > (http://te

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

> On May 27, 2014, 4:12 p.m., Andrew Lake wrote: > > Ship It! In case anyone is wondering why this arbitrary fellow said "Ship It!", I just wanted to provide an explicit thumbs up that this matches the 4px spacing basis grid recommended in the HIG (http://techbase.kde.org/Projects/Usability/H

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58586 --- Ship it! Ship It! - Andrew Lake On May 27, 2014, 9:42 a.m.

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58575 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 27, 2014, 9:

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

> On May 27, 2014, 1:11 p.m., Aleix Pol Gonzalez wrote: > > Makes sense, do we know why they used to be -1? > > If negative it would go into combinedLayoutSpacing which we don't implement. Which would in turn use the (now deprecated) defaultLayoutSpacing - David -

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58565 --- Makes sense, do we know why they used to be -1? - Aleix Pol

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 9:42 a.m.) Review request for Plasma, Andrew Lake,

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58545 --- File Attachment: compositing_kcm - bustle1.png

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- (Updated May 27, 2014, 9:25 a.m.) Review request for Plasma, Hugo Pereira

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/#review58542 --- Could you attach a screenshot of the Compositing KCM with the

Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- Review request for Plasma, Hugo Pereira Da Costa and Thomas Pfeiffer. Rep