Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/#review58868 --- This review has been submitted with commit f6c2bddb07b43ca857

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-31 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/ --- (Updated June 1, 2014, 2:34 a.m.) Status -- This change has been mar

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-31 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/ --- (Updated May 31, 2014, 10:33 p.m.) Review request for KDE Frameworks, Pla

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-31 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/#review58867 --- Ship it! I don't have anything against the patch, except that

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/#review58850 --- I'm happy with this. I think this should go in, even if there

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-30 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/ --- (Updated May 30, 2014, 11:42 p.m.) Review request for KDE Frameworks, Pla

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-29 Thread Matthew Dawson
> On May 29, 2014, 11:02 a.m., Alex Merry wrote: > > Did you try compiling this? Because that macro doesn't exist any more - > > there is an ecm_optional_add_subdirectory() in ECM if you > > include(ECMOptionalAddSubdirectory), though. > > > > However, I think an explicit option(), with a usef

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-29 Thread Matthew Dawson
> On May 29, 2014, 10:57 a.m., David Edmundson wrote: > > This doesn't look great to me. > > We'd have to release another 4.x. Is this too big for the KDE 4.13.x releases? It doesn't change the default behaviour, and as discussed in: https://git.reviewboard.kde.org/r/115602/ , this is the onl

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-29 Thread Alex Merry
> On May 29, 2014, 3:02 p.m., Alex Merry wrote: > > Did you try compiling this? Because that macro doesn't exist any more - > > there is an ecm_optional_add_subdirectory() in ECM if you > > include(ECMOptionalAddSubdirectory), though. > > > > However, I think an explicit option(), with a usefu

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-29 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/#review58733 --- Did you try compiling this? Because that macro doesn't exist a

Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/#review58731 --- This doesn't look great to me. We'd have to release another 4.

Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-26 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/ --- Review request for KDE Frameworks, Plasma and Ivan Čukić. Repository: kac