Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

2014-05-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/#review58724 --- Unfortunately this way we cannot have a plural aware suffix.

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

2014-05-29 Thread Aleix Pol Gonzalez
On May 29, 2014, 2:30 p.m., David Edmundson wrote: Unfortunately this way we cannot have a plural aware suffix. Then why port away? Linking against kde4libsupport seems like the lesser of two evils. Well then we need to decide how we're going to get to the proper fix. We can't just

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

2014-05-29 Thread David Edmundson
On May 29, 2014, 2:30 p.m., David Edmundson wrote: Unfortunately this way we cannot have a plural aware suffix. Then why port away? Linking against kde4libsupport seems like the lesser of two evils. Aleix Pol Gonzalez wrote: Well then we need to decide how we're going to get to

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

2014-05-29 Thread David Edmundson
On May 29, 2014, 2:30 p.m., David Edmundson wrote: Unfortunately this way we cannot have a plural aware suffix. Then why port away? Linking against kde4libsupport seems like the lesser of two evils. Aleix Pol Gonzalez wrote: Well then we need to decide how we're going to get to

Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

2014-05-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/#review58567 --- Unfortunately this way we cannot have a plural aware suffix.

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

2014-05-27 Thread Martin Klapetek
On May 27, 2014, 3:52 p.m., Martin Klapetek wrote: Unfortunately this way we cannot have a plural aware suffix. What if you do this from code like setSuffix(i18np(signular, plural, value)); ? Oh but that's not a binding so it won't auto update...too much time in QML xD Nevermind.

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

2014-05-27 Thread Martin Gräßlin
On May 27, 2014, 3:52 p.m., Martin Klapetek wrote: Unfortunately this way we cannot have a plural aware suffix. What if you do this from code like setSuffix(i18np(signular, plural, value)); ? Martin Klapetek wrote: Oh but that's not a binding so it won't auto update...too