Review Request 118351: [klipper] Port from KDialog to QDialog

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

2014-05-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/#review58577 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 27, 2014,

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

2014-05-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/#review58590 --- This review has been submitted with commit

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/ --- (Updated May 27, 2014, 4:48 p.m.) Status -- This change has been

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

2014-05-27 Thread Ömer Fadıl Usta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/#review58592 --- klipper/klipper.cpp

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

2014-05-27 Thread Martin Gräßlin
On May 27, 2014, 7:10 p.m., Ömer Fadıl Usta wrote: klipper/klipper.cpp, line 888 https://git.reviewboard.kde.org/r/118351/diff/1/?file=275367#file275367line888 is this a forgotten KDialog or on purpose ? it's on purpose. This is currently dead code (see the #ifdef HAVE_PRISON),