Re: Review Request 118357: Disable the agenda part of the calendar

2014-06-13 Thread Martin Klapetek
> On June 12, 2014, 12:25 p.m., Vishesh Handa wrote: > > I seem to have missed this change. > > > > The rationale behind this change is that there is no PIM support and > > therefore we should remove it. I'm sure you guys would have thought about > > the following points, but since the discuss

Re: Review Request 118357: Disable the agenda part of the calendar

2014-06-13 Thread Vishesh Handa
> On June 12, 2014, 10:25 a.m., Vishesh Handa wrote: > > I seem to have missed this change. > > > > The rationale behind this change is that there is no PIM support and > > therefore we should remove it. I'm sure you guys would have thought about > > the following points, but since the discuss

Re: Review Request 118357: Disable the agenda part of the calendar

2014-06-13 Thread Martin Klapetek
> On June 12, 2014, 12:25 p.m., Vishesh Handa wrote: > > I seem to have missed this change. > > > > The rationale behind this change is that there is no PIM support and > > therefore we should remove it. I'm sure you guys would have thought about > > the following points, but since the discuss

Re: Review Request 118357: Disable the agenda part of the calendar

2014-06-12 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review59861 --- I seem to have missed this change. The rationale behind this

Re: Review Request 118357: Disable the agenda part of the calendar

2014-06-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/ --- (Updated June 2, 2014, 12:44 p.m.) Status -- This change has been ma

Re: Review Request 118357: Disable the agenda part of the calendar

2014-06-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review58957 --- This review has been submitted with commit bfd62154d8e892d4fd

Re: Review Request 118357: Disable the agenda part of the calendar

2014-05-30 Thread Sebastian Kügler
> On May 30, 2014, 1:27 p.m., Sebastian Kügler wrote: > > Since the visible flag is now static false, let's comment the agenda item > > code, so we don't waste memory or CPU cycles. Once done, please ship. > > Martin Klapetek wrote: > I specifically opted out of commenting it as that would

Re: Review Request 118357: Disable the agenda part of the calendar

2014-05-30 Thread Sebastian Kügler
> On May 30, 2014, 1:27 p.m., Sebastian Kügler wrote: > > Since the visible flag is now static false, let's comment the agenda item > > code, so we don't waste memory or CPU cycles. Once done, please ship. > > Martin Klapetek wrote: > I specifically opted out of commenting it as that would

Re: Review Request 118357: Disable the agenda part of the calendar

2014-05-30 Thread Martin Klapetek
> On May 30, 2014, 3:27 p.m., Sebastian Kügler wrote: > > Since the visible flag is now static false, let's comment the agenda item > > code, so we don't waste memory or CPU cycles. Once done, please ship. I specifically opted out of commenting it as that would mean commenting stuff all around

Re: Review Request 118357: Disable the agenda part of the calendar

2014-05-30 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review58808 --- Ship it! Since the visible flag is now static false, let's co

Re: Review Request 118357: Disable the agenda part of the calendar

2014-05-30 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review58803 --- Ship it! Ship it since the changes look sane to me. Mind you,

Re: Review Request 118357: Disable the agenda part of the calendar

2014-05-29 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review58750 --- Ping? - Martin Klapetek On May 27, 2014, 6 p.m., Martin Kla

Re: Review Request 118357: Disable the agenda part of the calendar

2014-05-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review58588 --- I agree it makes sense, +1. Not adding "ship it" because the o

Review Request 118357: Disable the agenda part of the calendar

2014-05-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/ --- Review request for Plasma. Repository: plasma-workspace Description ---