Review Request 118581: Consider Super_L and Super_R as modifiers

2014-06-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/ --- Review request for KDE Frameworks, Plasma and Vishesh Handa. Bugs: 335316

Re: Review Request 118581: Consider Super_L and Super_R as modifiers

2014-06-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/#review59507 --- Ship it! Ship It! - David Faure On June 6, 2014, 12:39 a.m

Re: Review Request 118581: Consider Super_L and Super_R as modifiers

2014-06-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/#review59532 --- Ship it! Looks good to me. Can you check if we need to update

Re: Review Request 118581: Consider Super_L and Super_R as modifiers

2014-06-09 Thread Sebastian Kügler
> On June 7, 2014, 10:26 p.m., David Edmundson wrote: > > Looks good to me. > > Can you check if we need to update the the similar code in in > > kdeclarative->kquickcontrols too. (or poke me repeatedly to do it). > > It's broken there as well, fix is the same as this one: https://git.reviewbo

Re: Review Request 118581: Consider Super_L and Super_R as modifiers

2014-06-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/#review59637 --- This review has been submitted with commit d8e40e8579f559819a

Re: Review Request 118581: Consider Super_L and Super_R as modifiers

2014-06-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/ --- (Updated June 9, 2014, 10:06 p.m.) Status -- This change has been ma