Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

2014-06-20 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118849/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

2014-06-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118849/#review60604 --- this could maybe fix

Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

2014-06-20 Thread Aleix Pol Gonzalez
On June 20, 2014, 2:56 p.m., Marco Martin wrote: this could maybe fix https://bugs.kde.org/show_bug.cgi?id=336070 but i'm a bit on the fence. To me kida seems that to be really correct, one would allow either manually resizing popups xor allowing applets to resize themselves, the

Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

2014-06-20 Thread Vishesh Handa
On June 20, 2014, 2:56 p.m., Marco Martin wrote: this could maybe fix https://bugs.kde.org/show_bug.cgi?id=336070 but i'm a bit on the fence. To me kida seems that to be really correct, one would allow either manually resizing popups xor allowing applets to resize themselves, the

Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

2014-06-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118849/#review60607 --- Ship it! well, let's remove it for now - Marco Martin On

Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

2014-06-20 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118849/ --- (Updated June 20, 2014, 3:24 p.m.) Status -- This change has been

Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

2014-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118849/#review60608 --- This review has been submitted with commit