Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-23 Thread Raymond Wooninck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/#review60757 --- Hmm, now we seem to have a strange situation between KDE4 and

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-23 Thread Christoph Feck
On June 23, 2014, 9:16 a.m., Raymond Wooninck wrote: Hmm, now we seem to have a strange situation between KDE4 and KF5/PN. The latest version of libkonq with KDE4 is 5.14.0 (libkonq.so.5.14.0) with libkonq.so.5 pointing to it. With this change libkonq has a lower version

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-23 Thread Jonathan Riddell
On June 23, 2014, 9:16 a.m., Raymond Wooninck wrote: Hmm, now we seem to have a strange situation between KDE4 and KF5/PN. The latest version of libkonq with KDE4 is 5.14.0 (libkonq.so.5.14.0) with libkonq.so.5 pointing to it. With this change libkonq has a lower version

Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-20 Thread Scarlett Clark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/ --- Review request for Dolphin, KDE Base Apps, Plasma, and Jonathan Riddell.

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-20 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/#review60617 --- CMakeLists.txt

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-20 Thread Scarlett Clark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/ --- (Updated June 20, 2014, 11:44 a.m.) Review request for Dolphin, KDE Base

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-20 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/#review60618 --- CMakeLists.txt

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-20 Thread Scarlett Clark
On June 20, 2014, 12:02 p.m., Alex Merry wrote: CMakeLists.txt, line 23 https://git.reviewboard.kde.org/r/118851/diff/2/?file=282692#file282692line23 But now you'll want to put an actual version number in here (or remove the variable use altogether). I removed it all together,

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-20 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/#review60620 --- Ship it! Ship It! - Alex Merry On June 20, 2014, 6:44

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-20 Thread Scarlett Clark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/ --- (Updated June 20, 2014, 1:14 p.m.) Status -- This change has been