Re: Review Request 118914: [klipper] Fix memory leaks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118914/ --- (Updated Aug. 27, 2014, 8:56 a.m.) Status -- This change has been di

Re: Review Request 118914: [klipper] Fix memory leaks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118914/#review60896 --- Ship it! klipper/urlgrabber.cpp

Re: Review Request 118914: [klipper] Fix memory leaks

On June 24, 2014, 12:50 p.m., Martin Gräßlin wrote: > > Option 1: > > you make insert have a HistoryItem return value, for duplicates you return > > the original > > > > Option 2: > > We make history item implicitly shared and stop passing pointers all over > > the place both would be a rat

Re: Review Request 118914: [klipper] Fix memory leaks

> On June 24, 2014, 12:50 p.m., David Edmundson wrote: > > klipper/history.cpp, line 45 > > > > > > You have a potential crash here, the caller now has a dangling pointer. > > > > Klipper::applyClipChange

Re: Review Request 118914: [klipper] Fix memory leaks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118914/#review60888 --- klipper/history.cpp

Review Request 118914: [klipper] Fix memory leaks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118914/ --- Review request for Plasma. Repository: plasma-workspace Description ---