Re: Review Request 119781: Port TextArea to QtControls

2014-08-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/ --- (Updated Aug. 18, 2014, 9:35 a.m.) Status -- This change has been ma

Re: Review Request 119781: Port TextArea to QtControls

2014-08-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/#review64717 --- Ship it! See comments first. src/declarativeimports/plasmac

Re: Review Request 119781: Port TextArea to QtControls

2014-08-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/ --- (Updated Aug. 18, 2014, 9:25 a.m.) Review request for KDE Frameworks and

Re: Review Request 119781: Port TextArea to QtControls

2014-08-18 Thread Marco Martin
> On Aug. 17, 2014, 1:38 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml, line > > 30 > > > > > > I can see why you're doing this but I think this approach is

Re: Review Request 119781: Port TextArea to QtControls

2014-08-17 Thread David Edmundson
> On Aug. 17, 2014, 1:38 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml, line > > 30 > > > > > > I can see why you're doing this but I think this approach is

Re: Review Request 119781: Port TextArea to QtControls

2014-08-17 Thread Marco Martin
> On Aug. 17, 2014, 1:38 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml, line > > 30 > > > > > > I can see why you're doing this but I think this approach is

Re: Review Request 119781: Port TextArea to QtControls

2014-08-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/#review64672 --- src/declarativeimports/plasmacomponents/qml/styles/TextAreaSt

Re: Review Request 119781: Port TextArea to QtControls

2014-08-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/ --- (Updated Aug. 14, 2014, 11:10 a.m.) Review request for KDE Frameworks and

Re: Review Request 119781: Port TextArea to QtControls

2014-08-14 Thread Marco Martin
> On Aug. 14, 2014, 10:25 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/TextArea.qml, line 189 > > > > > > would this be useful upstream? not sure, is quite unusual for multiline c

Re: Review Request 119781: Port TextArea to QtControls

2014-08-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/#review64522 --- src/declarativeimports/plasmacomponents/qml/TextArea.qml

Review Request 119781: Port TextArea to QtControls

2014-08-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor