Re: Review Request 119927: Port systemloadviewer plasmoid

2014-08-27 Thread Martin Yrjölä
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/ --- (Updated Aug. 27, 2014, 5:02 p.m.) Status -- This change has been ma

Re: Review Request 119927: Port systemloadviewer plasmoid

2014-08-27 Thread Martin Yrjölä
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/ --- (Updated Aug. 27, 2014, 4:49 p.m.) Review request for Plasma and David Ed

Re: Review Request 119927: Port systemloadviewer plasmoid

2014-08-27 Thread Martin Yrjölä
> On Aug. 27, 2014, 4:33 p.m., Thomas Pfeiffer wrote: > > File Attachment: Screenshot - 2014-08-24-212539_505x860_scrot.png > > > > > > As already said in the forum thread: This violates the alignment HIG. > > Please put the checkboxes

Re: Review Request 119927: Port systemloadviewer plasmoid

2014-08-27 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/#review65378 --- File Attachment: Screenshot - 2014-08-24-212539_505x860_scrot

Re: Review Request 119927: Port systemloadviewer plasmoid

2014-08-27 Thread Thomas Pfeiffer
> On Aug. 25, 2014, 8 a.m., Martin Yrjölä wrote: > > File Attachment: Screenshot - 2014-08-24-212539_505x860_scrot.png > > > > > > I actually changed this string after the screenshot to "Use circular > > monitors", but you're right. Rad

Re: Review Request 119927: Port systemloadviewer plasmoid

2014-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/#review65326 --- Ship it! applets/systemloadviewer/package/contents/ui/Condit

Re: Review Request 119927: Port systemloadviewer plasmoid

2014-08-26 Thread Martin Yrjölä
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/ --- (Updated Aug. 26, 2014, 9:43 p.m.) Review request for Plasma and David Ed

Re: Review Request 119927: Port systemloadviewer plasmoid

2014-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/#review65217 --- applets/systemloadviewer/package/contents/ui/SystemLoadViewer

Re: Review Request 119927: Port systemloadviewer plasmoid

2014-08-25 Thread Martin Yrjölä
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/#review65173 --- File Attachment: Screenshot - 2014-08-24-212539_505x860_scrot

Re: Review Request 119927: Port systemloadviewer plasmoid

2014-08-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/#review65161 --- >There are regressions as well. These features aren't yet impl

Re: Review Request 119927: Port systemloadviewer plasmoid

2014-08-24 Thread Martin Yrjölä
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/#review65148 --- applets/systemloadviewer/package/contents/ui/GeneralSettings.

Review Request 119927: Port systemloadviewer plasmoid

2014-08-24 Thread Martin Yrjölä
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/ --- Review request for Plasma and David Edmundson. Repository: kdeplasma-addo