Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119946/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119946/#review65293 --- desktoppackage/contents/explorer/AppletAlternatives.qml

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119946/#review65295 --- Ship it! (as an extra note for other reading it: this

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread David Edmundson
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: desktoppackage/contents/explorer/AppletAlternatives.qml, line 131 https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line131 Why do we need this? (and if we do need it, it should go on the Switch button

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Marco Martin
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: desktoppackage/contents/explorer/AppletAlternatives.qml, line 34 https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line34 Why redeclare the property? ah, yes, didn't see it, it shouldn't redefine it - Marco

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Marco Martin
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: desktoppackage/contents/explorer/AppletAlternatives.qml, line 131 https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line131 Why do we need this? (and if we do need it, it should go on the Switch button

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread David Edmundson
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: desktoppackage/contents/explorer/AppletAlternatives.qml, line 131 https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line131 Why do we need this? (and if we do need it, it should go on the Switch button

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Marco Martin
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: desktoppackage/contents/explorer/AppletAlternatives.qml, line 131 https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line131 Why do we need this? (and if we do need it, it should go on the Switch button

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Marco Martin
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: desktoppackage/contents/explorer/AppletAlternatives.qml, line 131 https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line131 Why do we need this? (and if we do need it, it should go on the Switch button

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread David Edmundson
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: desktoppackage/contents/explorer/AppletAlternatives.qml, line 131 https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line131 Why do we need this? (and if we do need it, it should go on the Switch button

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Aaron J. Seigo
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote: desktoppackage/contents/explorer/AppletAlternatives.qml, line 34 https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line34 Why redeclare the property? Marco Martin wrote: ah, yes, didn't see it, it

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119946/ --- (Updated Aug. 26, 2014, 7:39 p.m.) Review request for Plasma.

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Aaron J. Seigo
On Aug. 26, 2014, 5:53 p.m., Marco Martin wrote: desktoppackage/contents/explorer/AppletAlternatives.qml, line 41 https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line41 omg, tabs? :p I'm not seeing any tabs there in the diff. The arrows just mean that the

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119946/#review65314 --- Ship it! Ship It! - Marco Martin On Aug. 26, 2014, 7:39

Re: Review Request 119946: Wrap the desktop alternatives UI in a dialog

2014-08-26 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119946/ --- (Updated Aug. 26, 2014, 7:46 p.m.) Status -- This change has been