---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119946/
---
Review request for Plasma.
Repository: plasma-desktop
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119946/#review65293
---
desktoppackage/contents/explorer/AppletAlternatives.qml
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119946/#review65295
---
Ship it!
(as an extra note for other reading it: this
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote:
desktoppackage/contents/explorer/AppletAlternatives.qml, line 131
https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line131
Why do we need this?
(and if we do need it, it should go on the Switch button
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote:
desktoppackage/contents/explorer/AppletAlternatives.qml, line 34
https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line34
Why redeclare the property?
ah, yes, didn't see it, it shouldn't redefine it
- Marco
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote:
desktoppackage/contents/explorer/AppletAlternatives.qml, line 131
https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line131
Why do we need this?
(and if we do need it, it should go on the Switch button
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote:
desktoppackage/contents/explorer/AppletAlternatives.qml, line 131
https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line131
Why do we need this?
(and if we do need it, it should go on the Switch button
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote:
desktoppackage/contents/explorer/AppletAlternatives.qml, line 131
https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line131
Why do we need this?
(and if we do need it, it should go on the Switch button
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote:
desktoppackage/contents/explorer/AppletAlternatives.qml, line 131
https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line131
Why do we need this?
(and if we do need it, it should go on the Switch button
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote:
desktoppackage/contents/explorer/AppletAlternatives.qml, line 131
https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line131
Why do we need this?
(and if we do need it, it should go on the Switch button
On Aug. 26, 2014, 5:49 p.m., David Edmundson wrote:
desktoppackage/contents/explorer/AppletAlternatives.qml, line 34
https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line34
Why redeclare the property?
Marco Martin wrote:
ah, yes, didn't see it, it
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119946/
---
(Updated Aug. 26, 2014, 7:39 p.m.)
Review request for Plasma.
On Aug. 26, 2014, 5:53 p.m., Marco Martin wrote:
desktoppackage/contents/explorer/AppletAlternatives.qml, line 41
https://git.reviewboard.kde.org/r/119946/diff/1/?file=307712#file307712line41
omg, tabs? :p
I'm not seeing any tabs there in the diff. The arrows just mean that the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119946/#review65314
---
Ship it!
Ship It!
- Marco Martin
On Aug. 26, 2014, 7:39
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119946/
---
(Updated Aug. 26, 2014, 7:46 p.m.)
Status
--
This change has been
15 matches
Mail list logo