Re: Review Request 120050: Wallpaper package structure fixes

2014-09-29 Thread Sebastian Kügler
> On Sept. 20, 2014, 6:22 a.m., Luca Beltrame wrote: > > This causes a regression: normal images can no longer be loaded. > > Plasmashell outputs > > > > No metadata file in the package, expected it at: > > "/path/to/parent/dir/of/wallpaper/metadata.desktop" > > Aaron J. Seigo wrote: > th

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-29 Thread Hrvoje Senjan
> On Sept. 20, 2014, 8:22 a.m., Luca Beltrame wrote: > > This causes a regression: normal images can no longer be loaded. > > Plasmashell outputs > > > > No metadata file in the package, expected it at: > > "/path/to/parent/dir/of/wallpaper/metadata.desktop" > > Aaron J. Seigo wrote: > th

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-29 Thread Sebastian Kügler
> On Sept. 20, 2014, 6:22 a.m., Luca Beltrame wrote: > > This causes a regression: normal images can no longer be loaded. > > Plasmashell outputs > > > > No metadata file in the package, expected it at: > > "/path/to/parent/dir/of/wallpaper/metadata.desktop" > > Aaron J. Seigo wrote: > th

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-29 Thread Hrvoje Senjan
> On Sept. 20, 2014, 8:22 a.m., Luca Beltrame wrote: > > This causes a regression: normal images can no longer be loaded. > > Plasmashell outputs > > > > No metadata file in the package, expected it at: > > "/path/to/parent/dir/of/wallpaper/metadata.desktop" > > Aaron J. Seigo wrote: > th

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-29 Thread Marco Martin
On Monday 29 September 2014, Sebastian Kügler wrote: > > There is also room for refactoring which could clean up some of the > > integration points which in turn would make testing a bit more > > straightforward. > > > > Hrvoje Senjan wrote: > > seems there is still regression in o

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-29 Thread Sebastian Kügler
> On Sept. 20, 2014, 6:22 a.m., Luca Beltrame wrote: > > This causes a regression: normal images can no longer be loaded. > > Plasmashell outputs > > > > No metadata file in the package, expected it at: > > "/path/to/parent/dir/of/wallpaper/metadata.desktop" > > Aaron J. Seigo wrote: > th

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-23 Thread Hrvoje Senjan
> On Sept. 20, 2014, 8:22 a.m., Luca Beltrame wrote: > > This causes a regression: normal images can no longer be loaded. > > Plasmashell outputs > > > > No metadata file in the package, expected it at: > > "/path/to/parent/dir/of/wallpaper/metadata.desktop" > > Aaron J. Seigo wrote: > th

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-20 Thread Aaron J. Seigo
> On Sept. 20, 2014, 6:22 a.m., Luca Beltrame wrote: > > This causes a regression: normal images can no longer be loaded. > > Plasmashell outputs > > > > No metadata file in the package, expected it at: > > "/path/to/parent/dir/of/wallpaper/metadata.desktop" > > Aaron J. Seigo wrote: > th

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-20 Thread Aleix Pol Gonzalez
> On set. 20, 2014, 6:22 a.m., Luca Beltrame wrote: > > This causes a regression: normal images can no longer be loaded. > > Plasmashell outputs > > > > No metadata file in the package, expected it at: > > "/path/to/parent/dir/of/wallpaper/metadata.desktop" > > Aaron J. Seigo wrote: > thi

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-20 Thread Aaron J. Seigo
> On Sept. 20, 2014, 6:22 a.m., Luca Beltrame wrote: > > This causes a regression: normal images can no longer be loaded. > > Plasmashell outputs > > > > No metadata file in the package, expected it at: > > "/path/to/parent/dir/of/wallpaper/metadata.desktop" this has been fixed. - Aaron J.

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-19 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review67019 --- This causes a regression: normal images can no longer be loade

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-19 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/ --- (Updated Sept. 19, 2014, 2:28 p.m.) Status -- This change has been m

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review66959 --- Ship it! Ship It! - Marco Martin On Sept. 19, 2014, 2:08 p

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-19 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/ --- (Updated Sept. 19, 2014, 2:08 p.m.) Review request for Plasma. Reposito

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-19 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/ --- (Updated Sept. 19, 2014, 12:53 p.m.) Review request for Plasma. Changes

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review65775 --- Ship it! plasmashell seems to correctly load the wallpaper, a

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-03 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/ --- (Updated Sept. 3, 2014, 5:49 p.m.) Review request for Plasma. Changes -

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review65774 --- wallpaperimages/ misses a CMAkeLists.txt (git add forgot?) -

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-03 Thread Marco Martin
> On Set. 3, 2014, 5 p.m., Marco Martin wrote: > > yes, the direction sounds sensible to me (err, shipit just after you finish it, as you note, mis-checked the checkbox) - Marco --- This is an automatically generated e-mail. To reply, v

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review65772 --- Ship it! yes, the direction sounds sensible to me - Marco Ma

Review Request 120050: Wallpaper package structure fixes

2014-09-03 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/ --- Review request for Plasma. Repository: plasma-workspace Description ---