Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/ --- (Updated Oct. 3, 2014, 9:41 a.m.) Status -- This change has been mar

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

> On Oct. 2, 2014, 4:04 p.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 231 > > > > > > Is this needed? > > Martin Klapetek wrote: > For tooltip? Otherwise I

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/ --- (Updated Oct. 2, 2014, 5:05 p.m.) Review request for Plasma. Changes --

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

> On Oct. 2, 2014, 4:04 p.m., Kai Uwe Broulik wrote: > > File Attachment: Variants in vertical panel - digital-clock2.png > > > > > > Is it the panel which makes it not look horizontally centered? I think so, the vertical variant has "L

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

> On Oct. 2, 2014, 3:57 p.m., Sebastian Kügler wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 216 > > > > > > There may be a corner case here, when the formfactor changes to Planar >

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/#review67813 --- Ship it! Ship It! - Kai Uwe Broulik On Okt. 2, 2014, 1:27

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/#review67812 --- File Attachment: Variants in vertical panel - digital-clock2.

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/#review67811 --- Ship it! Nice work! applets/digital-clock/package/contents/

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/#review67810 --- Ship it! I tried it a bit, it seems to work fine - Marco Mar

Re: Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/ --- (Updated Oct. 2, 2014, 3:27 p.m.) Review request for Plasma. Changes --

Review Request 120461: Refactor DigitalClock applet to use multiple labels and states

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120461/ --- Review request for Plasma. Repository: plasma-workspace Description ---