Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/ --- (Updated Oct. 15, 2014, 10:50 a.m.) Status -- This change has been m

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-14 Thread Marco Martin
> On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: > > src/quickaddons/managedtexturenode.h, line 52 > > > > > > even if will always remain just this member, just to me sure, it should > > be in a dpointer > > A

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-14 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/#review68396 --- src/quickaddons/imagetexturescache.h

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-14 Thread Vishesh Handa
> On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: > > src/quickaddons/managedtexturenode.h, line 52 > > > > > > even if will always remain just this member, just to me sure, it should > > be in a dpointer > > A

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-13 Thread Aleix Pol Gonzalez
> On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: > > src/quickaddons/managedtexturenode.h, line 52 > > > > > > even if will always remain just this member, just to me sure, it should > > be in a dpointer > > A

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-13 Thread Marco Martin
> On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: > > src/quickaddons/managedtexturenode.h, line 52 > > > > > > even if will always remain just this member, just to me sure, it should > > be in a dpointer > > A

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/ --- (Updated Oct. 13, 2014, 5:54 p.m.) Review request for KDE Frameworks, Pla