Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

2014-10-24 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 24, 2014, 4:42 p.m.) Status -- This change has been

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

2014-10-21 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 21, 2014, 9:06 a.m.) Review request for Plasma and Hugo

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

2014-10-21 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 21, 2014, 10 a.m.) Review request for Plasma and Hugo

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

2014-10-21 Thread Jonathan Riddell
On Oct. 19, 2014, 3:47 p.m., David Edmundson wrote: misc/gtkbreeze/main.cpp, line 96 https://git.reviewboard.kde.org/r/120624/diff/1/?file=320198#file320198line96 mid-long term we probably want to split this out into a file that we copy Otherwise this isn't really

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

2014-10-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/#review68848 --- Ship it! Looking mostly good to my eyes.

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

2014-10-20 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/#review68757 --- Found a bunch of issues around string handling, error

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

2014-10-20 Thread Jonathan Riddell
On Oct. 17, 2014, 5:59 p.m., Andrew Lake wrote: Sorry if it's too much trouble, but would you be able to do a screenshot showing a gtk app with these settings alongside a KF5 app? Jonathan Riddell wrote: http://people.ubuntu.com/~jr/tmp/breeze-gtk2.png GTK 2

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

2014-10-19 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- (Updated Oct. 19, 2014, 3:15 p.m.) Review request for Plasma and Hugo

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

2014-10-19 Thread Jonathan Riddell
On Oct. 17, 2014, 5:59 p.m., Andrew Lake wrote: Sorry if it's too much trouble, but would you be able to do a screenshot showing a gtk app with these settings alongside a KF5 app? http://people.ubuntu.com/~jr/tmp/breeze-gtk2.png GTK 2 http://people.ubuntu.com/~jr/tmp/breeze-gtk3.png GTK

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

2014-10-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/#review68708 --- misc/gtkbreeze/main.cpp

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

2014-10-19 Thread Martin Gräßlin
On Oct. 17, 2014, 7:59 p.m., Andrew Lake wrote: Sorry if it's too much trouble, but would you be able to do a screenshot showing a gtk app with these settings alongside a KF5 app? Jonathan Riddell wrote: http://people.ubuntu.com/~jr/tmp/breeze-gtk2.png GTK 2

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

2014-10-19 Thread Andrew Lake
On Oct. 17, 2014, 5:59 p.m., Andrew Lake wrote: Sorry if it's too much trouble, but would you be able to do a screenshot showing a gtk app with these settings alongside a KF5 app? Jonathan Riddell wrote: http://people.ubuntu.com/~jr/tmp/breeze-gtk2.png GTK 2

Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

2014-10-17 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/ --- Review request for Plasma. Repository: breeze Description --- add

Re: Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

2014-10-17 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120624/#review68621 --- Sorry if it's too much trouble, but would you be able to do a