Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/ --- (Updated Nov. 19, 2014, 10:39 a.m.) Status -- This change has been m

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/#review70598 --- Ship it! Ship It! - Marco Martin On Nov. 13, 2014, 6:24 p.

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-17 Thread Marco Martin
> On Nov. 14, 2014, 12:16 p.m., Marco Martin wrote: > > hm, i don't really like it. > > is it working around a problem in particular? > > if i try the patch, the difference during startup (or just duringopening a > > popup on the first time) is pretty noticeable like, the wallpaper appearing >

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-16 Thread Aleix Pol Gonzalez
> On Nov. 14, 2014, 12:16 p.m., Marco Martin wrote: > > hm, i don't really like it. > > is it working around a problem in particular? > > if i try the patch, the difference during startup (or just duringopening a > > popup on the first time) is pretty noticeable like, the wallpaper appearing >

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/#review70364 --- hm, i don't really like it. is it working around a problem in

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-13 Thread Aleix Pol Gonzalez
> On Nov. 13, 2014, 11:44 p.m., Albert Astals Cid wrote: > > +1 If you have to be blocking, use the proper blocking methods. Obviosuly > > it'd be better if no blocking call is used but since i know nothing about > > the code i'll just shut up now :D We've been going through the code with davi

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/#review70354 --- +1 If you have to be blocking, use the proper blocking methods

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/#review70338 --- +1, having this behaviour was a pain in the ass. Also it won't

Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative