---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121402/#review71782
---
Ship it!
Ship It!
- Martin Gräßlin
On Dec. 10, 2014, 3:47
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121402/
---
(Updated Dec. 11, 2014, 1:24 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121402/
---
(Updated Dec. 10, 2014, 2:47 p.m.)
Review request for Plasma.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121402/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121402/#review71618
---
+1 for me
- Marco Martin
On Dec. 9, 2014, 10:56 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121402/#review71619
---
ksmserver/screenlocker/kcm/kcm.ui
On Dec. 9, 2014, 11:01 a.m., Martin Gräßlin wrote:
ksmserver/screenlocker/kcm/kcm.ui, lines 84-104
https://git.reviewboard.kde.org/r/121402/diff/1/?file=332322#file332322line84
How does one switch back to the default background?
left click the button, you get a menu with two
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121402/#review71621
---
ksmserver/screenlocker/kcm/selectimagebutton.h
On Dec. 9, 2014, 11:52 a.m., Kai Uwe Broulik wrote:
lookandfeel/contents/lockscreen/LockScreen.qml, line 40
https://git.reviewboard.kde.org/r/121402/diff/1/?file=332325#file332325line40
if (status === Image.Error)
You also might want to avoid an endless loop when the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121402/
---
(Updated Dec. 9, 2014, 12:29 p.m.)
Review request for Plasma.
On Dec. 9, 2014, 12:01 p.m., Martin Gräßlin wrote:
lookandfeel/contents/lockscreen/LockScreen.qml, line 36
https://git.reviewboard.kde.org/r/121402/diff/1/?file=332325#file332325line36
shouldn't you compare whether backgroundPath is empty? That's checking
whether the variable is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121402/#review71648
---
ksmserver/screenlocker/kcm/selectimagebutton.cpp
12 matches
Mail list logo