Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

2014-12-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/#review71782 --- Ship it! Ship It! - Martin Gräßlin On Dec. 10, 2014, 3:47

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

2014-12-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/ --- (Updated Dec. 11, 2014, 1:24 p.m.) Status -- This change has been

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

2014-12-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/ --- (Updated Dec. 10, 2014, 2:47 p.m.) Review request for Plasma.

Review Request 121402: Allow user to customise wallpaper used in the lock screen.

2014-12-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

2014-12-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/#review71618 --- +1 for me - Marco Martin On Dec. 9, 2014, 10:56 a.m.,

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

2014-12-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/#review71619 --- ksmserver/screenlocker/kcm/kcm.ui

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

2014-12-09 Thread David Edmundson
On Dec. 9, 2014, 11:01 a.m., Martin Gräßlin wrote: ksmserver/screenlocker/kcm/kcm.ui, lines 84-104 https://git.reviewboard.kde.org/r/121402/diff/1/?file=332322#file332322line84 How does one switch back to the default background? left click the button, you get a menu with two

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

2014-12-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/#review71621 --- ksmserver/screenlocker/kcm/selectimagebutton.h

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

2014-12-09 Thread David Edmundson
On Dec. 9, 2014, 11:52 a.m., Kai Uwe Broulik wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 40 https://git.reviewboard.kde.org/r/121402/diff/1/?file=332325#file332325line40 if (status === Image.Error) You also might want to avoid an endless loop when the

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

2014-12-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/ --- (Updated Dec. 9, 2014, 12:29 p.m.) Review request for Plasma.

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

2014-12-09 Thread Martin Gräßlin
On Dec. 9, 2014, 12:01 p.m., Martin Gräßlin wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 36 https://git.reviewboard.kde.org/r/121402/diff/1/?file=332325#file332325line36 shouldn't you compare whether backgroundPath is empty? That's checking whether the variable is

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

2014-12-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/#review71648 --- ksmserver/screenlocker/kcm/selectimagebutton.cpp