On Jan. 27, 2015, 4:25 p.m., Ivan Čukić wrote:
Ship It!
@Xuetian Weng
Do you have commit access, or should I push this?
- Ivan
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122065/
---
(Updated Feb. 1, 2015, 10:39 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122065/#review74835
---
Ship it!
Ship It!
- Ivan Čukić
On Jan. 27, 2015, 4:18
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122065/
---
(Updated Jan. 27, 2015, 4:18 p.m.)
Review request for Plasma, Martin
On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote:
This looks still wrong to me. The service is still called org.kde.kwin
while it should be org.kde.KWin. Ideally this gets changed to a generated
adaptor from the DBus interface KWin installs.
To make things worse: the service name
On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote:
This looks still wrong to me. The service is still called org.kde.kwin
while it should be org.kde.KWin. Ideally this gets changed to a generated
adaptor from the DBus interface KWin installs.
To make things worse: the service name
On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote:
This looks still wrong to me. The service is still called org.kde.kwin
while it should be org.kde.KWin. Ideally this gets changed to a generated
adaptor from the DBus interface KWin installs.
To make things worse: the service name
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122065/#review74808
---
src/service/ksmserver/KSMServer.cpp
On Jan. 27, 2015, 8:27 a.m., Ivan Čukić wrote:
src/service/ksmserver/KSMServer.cpp, line 72
https://git.reviewboard.kde.org/r/122065/diff/2/?file=345332#file345332line72
Can you add:
- checking for the environment variable existence (and using it, if not
empty)
- a
On Jan. 27, 2015, 7:27 a.m., Ivan Čukić wrote:
src/service/ksmserver/KSMServer.cpp, line 72
https://git.reviewboard.kde.org/r/122065/diff/2/?file=345332#file345332line72
Can you add:
- checking for the environment variable existence (and using it, if not
empty)
- a
On Jan. 27, 2015, 8:27 a.m., Ivan Čukić wrote:
src/service/ksmserver/KSMServer.cpp, line 72
https://git.reviewboard.kde.org/r/122065/diff/2/?file=345332#file345332line72
Can you add:
- checking for the environment variable existence (and using it, if not
empty)
- a
On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote:
This looks still wrong to me. The service is still called org.kde.kwin
while it should be org.kde.KWin. Ideally this gets changed to a generated
adaptor from the DBus interface KWin installs.
To make things worse: the service name
On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote:
This looks still wrong to me. The service is still called org.kde.kwin
while it should be org.kde.KWin. Ideally this gets changed to a generated
adaptor from the DBus interface KWin installs.
To make things worse: the service name
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122065/
---
(Updated Jan. 27, 2015, 12:23 a.m.)
Review request for Plasma, Martin
On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote:
This looks still wrong to me. The service is still called org.kde.kwin
while it should be org.kde.KWin. Ideally this gets changed to a generated
adaptor from the DBus interface KWin installs.
To make things worse: the service name
On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote:
This looks still wrong to me. The service is still called org.kde.kwin
while it should be org.kde.KWin. Ideally this gets changed to a generated
adaptor from the DBus interface KWin installs.
To make things worse: the service name
On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote:
This looks still wrong to me. The service is still called org.kde.kwin
while it should be org.kde.KWin. Ideally this gets changed to a generated
adaptor from the DBus interface KWin installs.
To make things worse: the service name
On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote:
This looks still wrong to me. The service is still called org.kde.kwin
while it should be org.kde.KWin. Ideally this gets changed to a generated
adaptor from the DBus interface KWin installs.
To make things worse: the service name
On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote:
This looks still wrong to me. The service is still called org.kde.kwin
while it should be org.kde.KWin. Ideally this gets changed to a generated
adaptor from the DBus interface KWin installs.
To make things worse: the service name
On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote:
This looks still wrong to me. The service is still called org.kde.kwin
while it should be org.kde.KWin. Ideally this gets changed to a generated
adaptor from the DBus interface KWin installs.
To make things worse: the service name
On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote:
This looks still wrong to me. The service is still called org.kde.kwin
while it should be org.kde.KWin. Ideally this gets changed to a generated
adaptor from the DBus interface KWin installs.
To make things worse: the service name
On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote:
This looks still wrong to me. The service is still called org.kde.kwin
while it should be org.kde.KWin. Ideally this gets changed to a generated
adaptor from the DBus interface KWin installs.
To make things worse: the service name
On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote:
This looks still wrong to me. The service is still called org.kde.kwin
while it should be org.kde.KWin. Ideally this gets changed to a generated
adaptor from the DBus interface KWin installs.
To make things worse: the service name
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122065/#review74574
---
This looks still wrong to me. The service is still called
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122065/
---
Review request for Plasma and Ivan Čukić.
Repository: kactivities
25 matches
Mail list logo
