Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122184/ --- (Updated Jan. 22, 2015, 12:51 p.m.) Status -- This change has been m

Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122184/#review74518 --- Ship it! Looks good to me, although it sounds like something

Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-21 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122184/#review74495 --- you need to make sure the code also compiles with Qt4 (cmake -

Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122184/ --- (Updated Jan. 21, 2015, 4:57 p.m.) Review request for Plasma, David Faure

Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-21 Thread Hugo Pereira Da Costa
> On Jan. 21, 2015, 3:38 p.m., Hugo Pereira Da Costa wrote: > > the delete call was introduces by D. Faure, at > > 2ffe20e1bfe93c921c5372b4d21447b1de308d4b > > with log message: > > > > Fix crash on exit in all QCommandLineParser-based programs. > > > > Example: kioclient5 ls (= a syn

Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122184/ --- (Updated Jan. 21, 2015, 4:15 p.m.) Review request for Plasma, David Faure

Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-21 Thread David Edmundson
> On Jan. 21, 2015, 3:38 p.m., Hugo Pereira Da Costa wrote: > > the delete call was introduces by D. Faure, at > > 2ffe20e1bfe93c921c5372b4d21447b1de308d4b > > with log message: > > > > Fix crash on exit in all QCommandLineParser-based programs. > > > > Example: kioclient5 ls (= a syn

Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-21 Thread Hugo Pereira Da Costa
> On Jan. 21, 2015, 3:38 p.m., Hugo Pereira Da Costa wrote: > > the delete call was introduces by D. Faure, at > > 2ffe20e1bfe93c921c5372b4d21447b1de308d4b > > with log message: > > > > Fix crash on exit in all QCommandLineParser-based programs. > > > > Example: kioclient5 ls (= a syn

Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-21 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122184/#review74484 --- the delete call was introduces by D. Faure, at 2ffe20e1bfe93c

Re: Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122184/ --- (Updated Jan. 21, 2015, 3:34 p.m.) Review request for Plasma and Hugo Per

Review Request 122184: Remove seemingly outdated hack deleting the currently used QStyle at teardown

2015-01-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122184/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: oxygen