Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

> On Jan. 22, 2015, 11:07 a.m., Sebastian Kügler wrote: > > Code-wise, it has a few issues with the config saving and restoration, > > those are easily fixed, however. > > > > Otherwise, the problem is that we've frozen Plasma 4.x for more than a year > > already, so we won't accept new featur

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122196/ --- (Updated Jan. 22, 2015, 1:13 p.m.) Status -- This change has been di

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

> On Jan. 22, 2015, 11:07 a.m., Sebastian Kügler wrote: > > Code-wise, it has a few issues with the config saving and restoration, > > those are easily fixed, however. > > > > Otherwise, the problem is that we've frozen Plasma 4.x for more than a year > > already, so we won't accept new featur

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

> On Jan. 22, 2015, 11:07 a.m., Sebastian Kügler wrote: > > applets/binary-clock/binaryclock.cpp, line 179 > > > > > > I think you're forgetting to actually save the config value. Look at > > the cg.writeEntry(.

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

> On Jan. 22, 2015, 11:07 a.m., Sebastian Kügler wrote: > > Code-wise, it has a few issues with the config saving and restoration, > > those are easily fixed, however. > > > > Otherwise, the problem is that we've frozen Plasma 4.x for more than a year > > already, so we won't accept new featur

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122196/ --- (Updated Jan. 22, 2015, 12:54 p.m.) Review request for Plasma. Changes

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122196/ --- (Updated Jan. 22, 2015, 12:53 p.m.) Review request for Plasma. Reposito

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

> On Jan. 22, 2015, 11:07 a.m., Sebastian Kügler wrote: > > Code-wise, it has a few issues with the config saving and restoration, > > those are easily fixed, however. > > > > Otherwise, the problem is that we've frozen Plasma 4.x for more than a year > > already, so we won't accept new featur

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122196/#review74528 --- Code-wise, it has a few issues with the config saving and rest

Re: Review Request 122196: Offer the option to show per-field binary instead of per-digit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122196/#review74527 --- Hey. Thanks for writing a patch, at a quick glance it looks li

Review Request 122196: Offer the option to show per-field binary instead of per-digit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122196/ --- Review request for Plasma. Repository: kdeplasma-addons Description ---