---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122328/
---
(Updated Jan. 30, 2015, 2:41 p.m.)
Status
--
This change has been ma
On 01/30/2015 01:57 PM, Pinak Ahuja wrote:
Commit to master right?
Yes,
in fact, the code as changed quite some already between 5.2 and master,
and it might well be that the origin of the problem is unrelated to the
change your patch contains. Still, since it is a valid change, go ahead
and
Commit to master right?
On 30 Jan 2015 17:38, "Hugo Pereira Da Costa" wrote:
>This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122328/
>
> On January 30th, 2015, 12:01 p.m. UTC, *Hugo Pereira Da Costa* wrote:
>
> Ship It!
>
> PS: do you have com
> On Jan. 30, 2015, 12:01 p.m., Hugo Pereira Da Costa wrote:
> > Ship It!
PS: do you have commit access ? Otherwise I can commit for you.
- Hugo
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde
On 01/30/2015 12:58 PM, Pinak Ahuja wrote:
I might be wrong, but shouldn't the changed signal have a bool
parameter? The changed() without a parameter refers to a slot(can we
emit a slot? I'm new to this). I didn't compile and check if the
behaviour was fixed in the master branch without this
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122328/#review75041
---
Ship it!
Ship It!
- Hugo Pereira Da Costa
On Jan. 30, 2015
I might be wrong, but shouldn't the changed signal have a bool parameter?
The changed() without a parameter refers to a slot(can we emit a slot? I'm
new to this). I didn't compile and check if the behaviour was fixed in the
master branch without this patch, I have the problem with the plasma 5.2
pa
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122328/#review75040
---
I'm a bit confused. Could you first specify to which branch (m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122328/
---
Review request for Plasma and Hugo Pereira Da Costa.
Repository: breeze
