Re: Review Request 122331: Add libinput support to kcm-touchpad

> On Feb. 12, 2015, 1:39 a.m., David Edmundson wrote: > > Built my X with libinput support. > > > > Without this patch I get an erro, with this I get at least some options, > > though quite a few seemed disabled as they're just not available in > > libinput. > > Rajeesh K Nambiar wrote: >

Re: Review Request 122331: Add libinput support to kcm-touchpad

> On Feb. 12, 2015, 7:22 p.m., Rex Dieter wrote: > > The commit seems to have missed backends/x11/libinputproperties.c, it now > > fails to build for me: > > CMake Error at src/CMakeLists.txt:48 (add_library): > > Cannot find source file: > > > > backends/x11/libinputproperties.c > > Rex

Re: Review Request 122331: Add libinput support to kcm-touchpad

> On Feb. 12, 2015, 7:22 p.m., Rex Dieter wrote: > > The commit seems to have missed backends/x11/libinputproperties.c, it now > > fails to build for me: > > CMake Error at src/CMakeLists.txt:48 (add_library): > > Cannot find source file: > > > > backends/x11/libinputproperties.c Extract

Re: Review Request 122331: Add libinput support to kcm-touchpad

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331/#review75939 --- The commit seems to have missed backends/x11/libinputpropertie

Re: Review Request 122331: Add libinput support to kcm-touchpad

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331/ --- (Updated Feb. 12, 2015, 6:34 p.m.) Status -- This change has been ma

Re: Review Request 122331: Add libinput support to kcm-touchpad

> On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote: > > Built my X with libinput support. > > > > Without this patch I get an erro, with this I get at least some options, > > though quite a few seemed disabled as they're just not available in > > libinput. > > Rajeesh K Nambiar wrote: >

Re: Review Request 122331: Add libinput support to kcm-touchpad

> On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote: > > Built my X with libinput support. > > > > Without this patch I get an erro, with this I get at least some options, > > though quite a few seemed disabled as they're just not available in > > libinput. > > Rajeesh K Nambiar wrote: >

Re: Review Request 122331: Add libinput support to kcm-touchpad

> On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote: > > Built my X with libinput support. > > > > Without this patch I get an erro, with this I get at least some options, > > though quite a few seemed disabled as they're just not available in > > libinput. > > Rajeesh K Nambiar wrote: >

Re: Review Request 122331: Add libinput support to kcm-touchpad

> On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote: > > Built my X with libinput support. > > > > Without this patch I get an erro, with this I get at least some options, > > though quite a few seemed disabled as they're just not available in > > libinput. > > Rajeesh K Nambiar wrote: >

Re: Review Request 122331: Add libinput support to kcm-touchpad

> On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote: > > Built my X with libinput support. > > > > Without this patch I get an erro, with this I get at least some options, > > though quite a few seemed disabled as they're just not available in > > libinput. > > Rajeesh K Nambiar wrote: >

Re: Review Request 122331: Add libinput support to kcm-touchpad

> On Feb. 12, 2015, 12:39 a.m., David Edmundson wrote: > > Built my X with libinput support. > > > > Without this patch I get an erro, with this I get at least some options, > > though quite a few seemed disabled as they're just not available in > > libinput. Indeed, many options are disabled

Re: Review Request 122331: Add libinput support to kcm-touchpad

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331/#review75896 --- Ship it! Built my X with libinput support. Without this patc

Re: Review Request 122331: Add libinput support to kcm-touchpad

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331/#review75871 --- I tried testing the change. I added some debug into XlibBacken

Re: Review Request 122331: Add libinput support to kcm-touchpad

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331/#review75869 --- +1 from me. - David Edmundson On Jan. 30, 2015, 7:41 p.m.,

Re: Review Request 122331: Add libinput support to kcm-touchpad

> On Feb. 2, 2015, 7:56 a.m., Martin Gräßlin wrote: > > src/backends/x11/libinputproperties.c, line 34 > > > > > > C++11 nitpick: nullptr instead of NULL It's a C file, declared as extern array in cpp files. Also

Re: Review Request 122331: Add libinput support to kcm-touchpad

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331/#review75195 --- src/backends/x11/libinputproperties.c

Review Request 122331: Add libinput support to kcm-touchpad

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331/ --- Review request for Plasma, Alexander Mezin and Martin Gräßlin. Repository