---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/
---
Review request for Plasma and Daniel Vrátil.
Repository: kdeclarative
D
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/#review75062
---
src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplug
On Jan. 31, 2015, 3:41 a.m., Kai Uwe Broulik wrote:
> > I told you previously but I think you missed it, we have
> > PlasmaPlatformComponents.IconDialog, so lets not reinvent wheel. it is
> > already used by activity manager
We cannot at the same time tell people Plasma components and app comp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/#review75197
---
to do modality you have to use exec i guess
- Marco Martin
> On Feb. 2, 2015, 9:13 vorm., Marco Martin wrote:
> > to do modality you have to use exec i guess
I guess we don't want to black all of plasma just for this one dialog. So, we
go without modality then?
- Kai Uwe
---
This is an automat
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/
---
(Updated März 10, 2015, 8:03 nachm.)
Review request for Plasma and Daniel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/#review77270
---
I tried using setTransientParent but the windowHandle is null
> On March 10, 2015, 9:36 p.m., Kai Uwe Broulik wrote:
> > I tried using setTransientParent but the windowHandle is null before I show
> > the dialog but changing it afterwards doesn't work.
You can call m_dialog->winId() before, that will ensure that windowHandle is
created without needing to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/
---
(Updated März 11, 2015, 10:46 nachm.)
Review request for Plasma and Danie
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/
---
(Updated März 14, 2015, 9:41 vorm.)
Review request for Plasma and Daniel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/#review77930
---
In general +100. Two minor comments.
src/qmlcontrols/kquickc
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/
---
(Updated März 23, 2015, 6:53 nachm.)
Review request for Plasma and Daniel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/#review77990
---
Ship it!
+1 from me.
Remember I asked you to shove in a test
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/
---
(Updated März 24, 2015, 6:53 nachm.)
Review request for Plasma and Daniel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/
---
(Updated March 25, 2015, 5:18 p.m.)
Status
--
This change has been m
15 matches
Mail list logo
