Re: Review Request 122419: [screenlocker] Support global shortcuts in the lock screen

2015-02-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122419/ --- (Updated Feb. 6, 2015, 7:22 a.m.) Status -- This change has been mar

Re: Review Request 122419: [screenlocker] Support global shortcuts in the lock screen

2015-02-05 Thread Martin Gräßlin
> On Feb. 5, 2015, 8:20 p.m., David Edmundson wrote: > > ksmserver/screenlocker/lockwindow.h, line 41 > > > > > > Personally I'd pass the GlobalAccel in the ctor. You have it available, > > then you don't need to

Re: Review Request 122419: [screenlocker] Support global shortcuts in the lock screen

2015-02-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122419/#review75492 --- Ship it! ksmserver/screenlocker/lockwindow.h

Re: Review Request 122419: [screenlocker] Support global shortcuts in the lock screen

2015-02-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122419/ --- (Updated Feb. 5, 2015, 8:58 a.m.) Review request for Plasma. Changes --

Re: Review Request 122419: [screenlocker] Support global shortcuts in the lock screen

2015-02-04 Thread Martin Gräßlin
> On Feb. 4, 2015, 11:28 a.m., David Edmundson wrote: > > ksmserver/screenlocker/globalaccel.cpp, line 273 > > > > > > you're not handling emacs style shortcuts here. AFAIK emacs style shortcuts are not supporte

Re: Review Request 122419: [screenlocker] Support global shortcuts in the lock screen

2015-02-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122419/#review75369 --- ksmserver/screenlocker/globalaccel.cpp

Review Request 122419: [screenlocker] Support global shortcuts in the lock screen

2015-02-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122419/ --- Review request for Plasma. Bugs: 198097 https://bugs.kde.org/show_bug