Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

2015-02-10 Thread David Edmundson
On Feb. 10, 2015, 1:33 p.m., David Edmundson wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 161 https://git.reviewboard.kde.org/r/122511/diff/1/?file=348176#file348176line161 Make sure you test this actually gets called when you switch VTs. It will require

Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

2015-02-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122511/ --- (Updated Feb. 10, 2015, 3:04 p.m.) Status -- This change has been

Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

2015-02-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122511/#review75791 --- Ship it! Ship It! - David Edmundson On Feb. 10, 2015,

Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

2015-02-10 Thread Martin Gräßlin
On Feb. 10, 2015, 2:33 p.m., David Edmundson wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 161 https://git.reviewboard.kde.org/r/122511/diff/1/?file=348176#file348176line161 Make sure you test this actually gets called when you switch VTs. It will require

Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

2015-02-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122511/#review75785 --- FWIW, I think that's a good idea. As David says, make sure to

Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

2015-02-10 Thread Martin Gräßlin
On Feb. 10, 2015, 2:33 p.m., David Edmundson wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 161 https://git.reviewboard.kde.org/r/122511/diff/1/?file=348176#file348176line161 Make sure you test this actually gets called when you switch VTs. It will require

Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

2015-02-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122511/#review75778 --- Ship it! lookandfeel/contents/lockscreen/LockScreen.qml

Re: Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

2015-02-10 Thread David Edmundson
On Feb. 10, 2015, 1:33 p.m., David Edmundson wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 161 https://git.reviewboard.kde.org/r/122511/diff/1/?file=348176#file348176line161 Make sure you test this actually gets called when you switch VTs. It will require

Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

2015-02-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122511/ --- Review request for Plasma. Bugs: 326633