Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/ --- Review request for Plasma and Martin Klapetek. Bugs: 343872 https://b

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/#review76128 --- Does this still work as intended even when seconds are shown?

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/#review76131 --- All I'm getting with this patch is "Error loading QML file: f

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Bhushan Shah
> On Feb. 16, 2015, 8:36 p.m., Martin Klapetek wrote: > > All I'm getting with this patch is "Error loading QML file: > > file:///opt/kde5/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/main.qml:57:9: > > Cannot assign to non-existent property "intervalAlignment" " > > > > And

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Martin Klapetek
> On Feb. 16, 2015, 4:06 p.m., Martin Klapetek wrote: > > All I'm getting with this patch is "Error loading QML file: > > file:///opt/kde5/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/main.qml:57:9: > > Cannot assign to non-existent property "intervalAlignment" " > > > > And

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/#review76138 --- applets/digital-clock/package/contents/ui/main.qml

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Kai Uwe Broulik
> On Feb. 16, 2015, 3:53 nachm., Marco Martin wrote: > > applets/digital-clock/package/contents/ui/main.qml, line 57 > > > > > > perhaps should be noalignment when showing seconds? (however is very > > weird that

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/ --- (Updated Feb. 16, 2015, 4:04 nachm.) Review request for Plasma and Martin

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Marco Martin
> On Feb. 16, 2015, 3:53 p.m., Marco Martin wrote: > > applets/digital-clock/package/contents/ui/main.qml, line 57 > > > > > > perhaps should be noalignment when showing seconds? (however is very > > weird that i

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/#review76143 --- Ship it! Ship It! - Marco Martin On Feb. 16, 2015, 4:04 p.

Re: Review Request 122592: Align digital clock to full minutes

2015-02-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122592/ --- (Updated Feb. 16, 2015, 5:48 p.m.) Status -- This change has been ma