Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-03-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/ --- (Updated March 10, 2016, 1:02 p.m.) Status -- This change has been m

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-03-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/#review93351 --- Ship it! Ship It! - Marco Martin On March 9, 2016, 4:39

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-03-09 Thread Kai Uwe Broulik
> On März 9, 2016, 4:56 nachm., Marco Martin wrote: > > the patch is fine, but it's the one about not using unneeded loadPixmp, not > > the one about not animating when hidden? yeah disregard the unittest, sorry, just need to remove the qexpectfail - Kai Uwe

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-03-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/#review93347 --- the patch is fine, but it's the one about not using unneeded

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-03-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/ --- (Updated März 9, 2016, 4:39 nachm.) Review request for Plasma. Changes

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-03-09 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/#review93328 --- src/declarativeimports/core/iconitem.h (line 129)

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-03-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/ --- (Updated März 9, 2016, 10:29 vorm.) Review request for Plasma. Changes

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-02-17 Thread Marco Martin
> On Dec. 28, 2015, 9:50 a.m., David Rosca wrote: > > What about just adding a property to disable animation (as Eike suggested) > > and disable it for icon in tooltips? > > > > Currently, only the icon is animated when the tooltip contents change, text > > (tooltip title, subtitle) is changed

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-02-17 Thread David Rosca
> On Dec. 28, 2015, 9:50 a.m., David Rosca wrote: > > What about just adding a property to disable animation (as Eike suggested) > > and disable it for icon in tooltips? > > > > Currently, only the icon is animated when the tooltip contents change, text > > (tooltip title, subtitle) is changed

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-02-17 Thread Marco Martin
> On Dec. 28, 2015, 9:50 a.m., David Rosca wrote: > > What about just adding a property to disable animation (as Eike suggested) > > and disable it for icon in tooltips? > > > > Currently, only the icon is animated when the tooltip contents change, text > > (tooltip title, subtitle) is changed

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-02-17 Thread David Rosca
> On Dec. 28, 2015, 12:50 a.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 405 > > > > > > huh? that just reloads the current image whenever visibility gets > > toggled. > >

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-02-17 Thread Kai Uwe Broulik
> On Dez. 28, 2015, 12:50 vorm., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 405 > > > > > > huh? that just reloads the current image whenever visibility gets > > toggled. > >

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-02-17 Thread David Rosca
> On Dec. 28, 2015, 12:50 a.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 405 > > > > > > huh? that just reloads the current image whenever visibility gets > > toggled. > >

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2015-12-28 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/#review90201 --- What about just adding a property to disable animation (as Eik

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2015-12-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/#review90189 --- src/declarativeimports/core/iconitem.cpp (line 405)

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2015-12-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/ --- (Updated Dez. 28, 2015, 12:17 vorm.) Review request for Plasma. Changes