Re: Review Request 122921: Handle job error when showing job finished notification

2015-03-22 Thread David Rosca
On March 22, 2015, 11:36 a.m., Kai Uwe Broulik wrote: applets/notifications/package/contents/ui/Jobs.qml, line 69 https://git.reviewboard.kde.org/r/122921/diff/1/?file=354553#file354553line69 Just noticed, shouldn't it rather be Failed? So you get Copying: Failed rather

Re: Review Request 122921: Handle job error when showing job finished notification

2015-03-22 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122921/#review77905 --- applets/notifications/package/contents/ui/Jobs.qml (line 69)

Review Request 122921: Handle job error when showing job finished notification

2015-03-12 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122921/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 122921: Handle job error when showing job finished notification

2015-03-12 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122921/ --- (Updated March 12, 2015, 5:46 p.m.) Status -- This change has been

Re: Review Request 122921: Handle job error when showing job finished notification

2015-03-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122921/#review77390 --- Ship it! Thanks for doing this - David Edmundson On March