Re: Review Request 123332: Timer: Added config ui for notification and title text

On April 15, 2015, 7:49 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 44 https://git.reviewboard.kde.org/r/123332/diff/2/?file=361044#file361044line44 This is the line that doesn't work. Layout.property is a hint for the

Re: Review Request 123332: Timer: Added config ui for notification and title text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- (Updated April 17, 2015, 8:02 nachm.) Review request for Plasma.

Re: Review Request 123332: Timer: Added config ui for notification and title text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/#review79145 --- Ship it! Ship It! - David Edmundson On April 17, 2015,

Re: Review Request 123332: Timer: Added config ui for notification and title text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- (Updated April 17, 2015, 8:16 nachm.) Status -- This change has

Re: Review Request 123332: Timer: Added config ui for notification and title text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/#review78989 --- applets/timer/package/contents/ui/configAppearance.qml (line

Re: Review Request 123332: Timer: Added config ui for notification and title text

On April 13, 2015, 7:40 p.m., David Edmundson wrote: Ship It! Bernhard Friedreich wrote: sorry for the misunderstanding but the TextEdits still don't resize to the windowsize.. (see the open issue) I've just updated the review request with my latest tries about the fillWidth

Re: Review Request 123332: Timer: Added config ui for notification and title text

On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? Bernhard Friedreich wrote: using

Re: Review Request 123332: Timer: Added config ui for notification and title text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- (Updated April 13, 2015, 7:33 nachm.) Review request for Plasma.

Re: Review Request 123332: Timer: Added config ui for notification and title text

On April 11, 2015, 5 p.m., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? Bernhard Friedreich wrote: using

Re: Review Request 123332: Timer: Added config ui for notification and title text

On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? Bernhard Friedreich wrote: using

Re: Review Request 123332: Timer: Added config ui for notification and title text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/#review78905 --- Ship it! Ship It! - David Edmundson On April 13, 2015,

Re: Review Request 123332: Timer: Added config ui for notification and title text

On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? Bernhard Friedreich wrote: using

Re: Review Request 123332: Timer: Added config ui for notification and title text

On April 13, 2015, 7:40 nachm., David Edmundson wrote: Ship It! sorry for the misunderstanding but the TextEdits still don't resize to the windowsize.. (see the open issue) I've just updated the review request with my latest tries about the fillWidth everywhere.. - Bernhard

Re: Review Request 123332: Timer: Added config ui for notification and title text

On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? Bernhard Friedreich wrote: using

Re: Review Request 123332: Timer: Added config ui for notification and title text

On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? Bernhard Friedreich wrote: using

Re: Review Request 123332: Timer: Added config ui for notification and title text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/#review78812 --- applets/timer/package/contents/config/main.xml (line 33)

Re: Review Request 123332: Timer: Added config ui for notification and title text

On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? using QtLayouts.Layout.fillWidth: true doesn't work for me

Review Request 123332: Timer: Added config ui for notification and title text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- Review request for Plasma. Repository: kdeplasma-addons Description